[Asterisk-code-review] Local channels: Do not block control -1 payloads. (asterisk[master])

[Joshua Colp]

Joshua Colp has submitted this change and it was merged.

Change subject: Local channels: Do not block control -1 payloads.
......................................................................


Local channels: Do not block control -1 payloads.

Control frames with a -1 payload are used as a special signal to stop
playtones generators on channels. This indication is sent both by
app_dial as well as by ast_answer() when a call is answered in case any
tones were being generated on a calling channel.

This control frame type was made to stop traversing local channel pairs
as an optimization, because it was thought that it was unnecessary to
send these indications, and allowing such unnecessary control frames to
traverse the local channels would cause the local channels to optimize
away less quickly.

As it turns out, through some special magic dialplan code, it is
possible to have a tones being played on a non-local channel, and it is
important for the local channel to convey that the tones should be
stopped. The result of having tones continue to be played on the
non-local channel is that the tones play even once the channel has been
bridged. By not blocking the -1 control frame type, we can ensure that
this situation does not happen.

ASTERISK-25250 #close
Reported by Etienne Lessard

Change-Id: I0bcaac3d70b619afdbd0ca8a8dd708f33fd2f815
---
M main/core_unreal.c
1 file changed, 1 insertion(+), 6 deletions(-)

Approvals:
  Richard Mudgett: Looks good to me, but someone else must approve
  Anonymous Coward #1000019: Verified
  Joshua Colp: Looks good to me, approved



diff --git a/main/core_unreal.c b/main/core_unreal.c
index 55b4ea3..411cc51 100644
--- a/main/core_unreal.c
+++ b/main/core_unreal.c
@@ -409,12 +409,7 @@
 	int isoutbound;
 
 	ao2_lock(p);
-	/*
-	 * Block -1 stop tones events if we are to be optimized out.  We
-	 * don't need a flurry of these events on an unreal channel chain
-	 * when initially connected to slow the optimization process.
-	 */
-	if (0 <= condition || ast_test_flag(p, AST_UNREAL_NO_OPTIMIZATION)) {
+	if (ast_test_flag(p, AST_UNREAL_NO_OPTIMIZATION)) {
 		struct ast_frame f = {
 			.frametype = AST_FRAME_CONTROL,
 			.subclass.integer = condition,

-- 
To view, visit https://gerrit.asterisk.org/951
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I0bcaac3d70b619afdbd0ca8a8dd708f33fd2f815
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>