[Asterisk-code-review] holding bridge: ensure moh participants get frames (asterisk[13])

[Kevin Harwell]

Kevin Harwell has posted comments on this change.

Change subject: holding_bridge: ensure moh participants get frames
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.asterisk.org/#/c/920/1//COMMIT_MSG
Commit Message:

Line 8: 
      : Currently, if a blank musiconhold.conf is used, musiconhold will fail
      : to start for a channel going into a holding bridge with an anticipation
      : of getting music on hold. That being the case, no frames will be written
      : to the channel and that can pose a problem for blind transfers in PJSIP
      : which may rely on frames being written to get past the REFER framehook.
      : This patch makes holding bridges start a silence generator if starting
      : music on hold fails and makes it so that if no music on hold functions
      : are installed that the ast_moh_start function will report a failure so
      : that consumers of that function will be able to respond appropriately.
      : 
      : Change-Id: I06f066728604943cba0bb0b39fa7cf658a21cd99
> This needs an ASTERISK issue filed for it.
I went ahead and created one for it: ASTERISK-25271


-- 
To view, visit https://gerrit.asterisk.org/920
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I06f066728604943cba0bb0b39fa7cf658a21cd99
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Jonathan Rose <jrose at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Matt Jordan <mjordan at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes