[Asterisk-code-review] Documentation: A couple of trivial fixes in sip.conf.sample ... (asterisk[master])

[Joshua Colp]

Joshua Colp has submitted this change and it was merged.

Change subject: Documentation: A couple of trivial fixes in sip.conf.sample and func_cdr.c
......................................................................


Documentation: A couple of trivial fixes in sip.conf.sample and func_cdr.c

 * In sip.conf.sample fix sentence where we said that WS or WSS are supported
   transports for use in an outbound register definition. They are not
   supported in that case.
 * In func_cdr.c made it clear that the Disable option for CDR_PROP can be used
   to enable CDR on a channel.

ASTERISK-24867 #close
Reported by: Rusty Newton

ASTERISK-24853 #close
Reported by: PSDK

Change-Id: I3d698bc6302b9d00a0a995b5c4ad9a42d69b48ca
---
M configs/samples/sip.conf.sample
M funcs/func_cdr.c
2 files changed, 3 insertions(+), 2 deletions(-)

Approvals:
  Richard Mudgett: Looks good to me, but someone else must approve
  Anonymous Coward #1000019: Verified
  Joshua Colp: Looks good to me, approved



diff --git a/configs/samples/sip.conf.sample b/configs/samples/sip.conf.sample
index 71e3fb7..4d06243 100644
--- a/configs/samples/sip.conf.sample
+++ b/configs/samples/sip.conf.sample
@@ -810,7 +810,7 @@
 ;
 ;register => tls://username:xxxxxx@sip-tls-proxy.example.org
 ;
-;    The 'transport' part defaults to 'udp' but may also be 'tcp', 'tls', 'ws', or 'wss'.
+;    The 'transport' part defaults to 'udp' but may also be 'tcp' or 'tls'.
 ;    Using 'udp://' explicitly is also useful in case the username part
 ;    contains a '/' ('user/name').
 
diff --git a/funcs/func_cdr.c b/funcs/func_cdr.c
index 2bb6a8e..8d98479 100644
--- a/funcs/func_cdr.c
+++ b/funcs/func_cdr.c
@@ -180,7 +180,8 @@
 						<para>Write-Only</para>
 					</enum>
 					<enum name="disable">
-						<para>Disable CDRs for this channel.</para>
+						<para>Setting to 1 will disable CDRs for this channel.
+						Setting to 0 will enable CDRs for this channel.</para>
 						<para>Write-Only</para>
 					</enum>
 				</enumlist>

-- 
To view, visit https://gerrit.asterisk.org/935
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I3d698bc6302b9d00a0a995b5c4ad9a42d69b48ca
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Rusty Newton <rnewton at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>