[Asterisk-code-review] chan pjsip: Don't change formats when frame of unsupported f... (asterisk[master])

[Matt Jordan]

Matt Jordan has posted comments on this change.

Change subject: chan_pjsip: Don't change formats when frame of unsupported format is received.
......................................................................


Patch Set 1:

> With the current state of format capabilities the comparison is an
 > index into an array, and then a function call if a compatibility
 > implementation is done. It should be minor, even if called a lot.

IIRC, from past performance results, that compatibility callback isn't always minor when called repeatedly.

-- 
To view, visit https://gerrit.asterisk.org/905
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If93d641fb6418a285928839300d7854cab8c1020
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Matt Jordan <mjordan at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: No