[Asterisk-code-review] ARI: Added new functionality to reload a single module. (asterisk[13])

[Ashley Sanders]

Ashley Sanders has posted comments on this change.

Change subject: ARI: Added new functionality to reload a single module.
......................................................................


Patch Set 1: Code-Review-1

(4 comments)

https://gerrit.asterisk.org/#/c/858/1/res/ari/resource_asterisk.c
File res/ari/resource_asterisk.c:

Line 160: ast_verb(0, "made it here\n");
Should this be removed?


Line 163: 	"Module does not exist"
This is the same comment from review #808 regarding this message:

I think that this message should denote that we tried to find the specified resource in order to reload it, but it wasn't currently in our list of running modules, which is a bit different than stating that it does not exist at all. 

Consider something like the following, "Specified module was not found in running modules." (or something to that effect), would give the user an idea that the module may exist in the system (or it may not), but for our purposes, we only looked in the running modules and couldn't find it.


Line 177: "An error occurred while reloading the module"
I think this should be rephrased to state 'An unspecified error occurred while reloading the module.'


https://gerrit.asterisk.org/#/c/858/1/rest-api/api-docs/asterisk.json
File rest-api/api-docs/asterisk.json:

Line 67: "reason": "Module does not exist."
I put a comment in resource_asterisk.c stating my position for changing this message. There are also a couple of comments on review #808.


-- 
To view, visit https://gerrit.asterisk.org/858
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I289188bcae182b2083bdbd9ebfffd50b62f58ae1
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Ashley Sanders <asanders at digium.com>
Gerrit-HasComments: Yes