[Asterisk-code-review] ARI: Added new functionality to unload a single module. (asterisk[13])

[Ashley Sanders]

Ashley Sanders has posted comments on this change.

Change subject: ARI: Added new functionality to unload a single module.
......................................................................


Patch Set 3: Code-Review-1

(2 comments)

https://gerrit.asterisk.org/#/c/808/3/res/ari/resource_asterisk.c
File res/ari/resource_asterisk.c:

Line 163: "Module does not exist"
I think that this message should denote that we tried to find the specified resource in order to unload it, but it wasn't currently in our list of running modules, which is a bit different than stating that it does not exist at all. 

Consider something like the following, "Specified module was not found in running modules." (or something to that effect), would give the user an idea that the module may exist in the system (or it may not), but for our purposes, we only looked in the running modules and couldn't find it.


https://gerrit.asterisk.org/#/c/808/3/rest-api/api-docs/asterisk.json
File rest-api/api-docs/asterisk.json:

Line 67: "reason": "Module does not exist."
I have the same response for this as I did for resource_asterisk.c, line 163.


-- 
To view, visit https://gerrit.asterisk.org/808
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I535a95f5676deb02651522761ecbdc0b00b5ac57
Gerrit-PatchSet: 3
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Ashley Sanders <asanders at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-HasComments: Yes