[Asterisk-code-review] ARI: Added new functionality to get information on a single ... (asterisk[13])

[Ashley Sanders]

Ashley Sanders has posted comments on this change.

Change subject: ARI: Added new functionality to get information on a single module.
......................................................................


Patch Set 8:

(1 comment)

https://gerrit.asterisk.org/#/c/790/8/rest-api/api-docs/asterisk.json
File rest-api/api-docs/asterisk.json:

Line 60: 					"nickname": "getModule",
As I am looking at this now, and I apologize for not catching this much sooner, I wonder if this should be getModuleInfo rather than getModule, since it is only providing module information and not the actual module. 

Even your 409 error response message indicates that the action attempted (which subsequently failed) was to get the module information.

Also, if you look at the other functions in ARI, a great deal of them are handling some kind of 'info' object, e.g. asterisk_info, config_info, build_info, status_info, etc.


-- 
To view, visit https://gerrit.asterisk.org/790
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibce5a94e70ecdf4e90329cf0ba66c33a62d37463
Gerrit-PatchSet: 8
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Ashley Sanders <asanders at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Matt Jordan <mjordan at digium.com>
Gerrit-HasComments: Yes