[Asterisk-code-review] bridge.c: Fixed race condition during attended transfer (asterisk[13])

Richard Mudgett asteriskteam at digium.com
Mon Jul 13 12:06:56 CDT 2015


Richard Mudgett has posted comments on this change.

Change subject: bridge.c: Fixed race condition during attended transfer
......................................................................


Patch Set 4: Code-Review-1

(2 comments)

https://gerrit.asterisk.org/#/c/839/4/main/bridge.c
File main/bridge.c:

Line 3976: 		if (b2) ast_bridge_lock_both(b1, b2);	\
         : 		else ast_bridge_lock(b1); \
Still no curlies here.

Guess I'll have to make multiple issues with lines more explicit.  :)


Line 4012: 	 * core_local may call into it then the bridges needs to be unlocked here.
There were two items pointed out for this line in the last review you only did one:
...bridges need to...


-- 
To view, visit https://gerrit.asterisk.org/839
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I08fe33a2560da924e676df55b181e46fca604577
Gerrit-PatchSet: 4
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes



More information about the asterisk-code-review mailing list