[Asterisk-code-review] res/res sorcery memory cache: Fix test registration issues (asterisk[13])

Matt Jordan asteriskteam at digium.com
Fri Jul 10 22:27:11 CDT 2015


Matt Jordan has uploaded a new change for review.

  https://gerrit.asterisk.org/869

Change subject: res/res_sorcery_memory_cache: Fix test registration issues
......................................................................

res/res_sorcery_memory_cache: Fix test registration issues

Again, tests now need to not end with a newline. This patch makes it so
the tests can register again, unit tests will actually pass, and we can
stop wasting time trying to figure out why builds are failing when they
really aren't failing.

Change-Id: Ide519fbeba89f413c733446c5ff7b224fc4ce840
---
M res/res_sorcery_memory_cache.c
1 file changed, 8 insertions(+), 8 deletions(-)


  git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/69/869/1

diff --git a/res/res_sorcery_memory_cache.c b/res/res_sorcery_memory_cache.c
index f0fc055..33e78d1 100644
--- a/res/res_sorcery_memory_cache.c
+++ b/res/res_sorcery_memory_cache.c
@@ -1602,7 +1602,7 @@
 			"\t* Creates a memory cache with default configuration\n"
 			"\t* Creates a memory cache with a maximum object count of 10 and verifies it\n"
 			"\t* Creates a memory cache with a maximum object lifetime of 60 and verifies it\n"
-			"\t* Creates a memory cache with a stale object lifetime of 90 and verifies it\n";
+			"\t* Creates a memory cache with a stale object lifetime of 90 and verifies it";
 		return AST_TEST_NOT_RUN;
 	case TEST_EXECUTE:
 		break;
@@ -1673,7 +1673,7 @@
 			"\t* Create a memory cache with a maximum object lifetime of -1\n"
 			"\t* Create a memory cache with a maximum object lifetime of toast\n"
 			"\t* Create a memory cache with a stale object lifetime of -1\n"
-			"\t* Create a memory cache with a stale object lifetime of toast\n";
+			"\t* Create a memory cache with a stale object lifetime of toast";
 		return AST_TEST_NOT_RUN;
 	case TEST_EXECUTE:
 		break;
@@ -1756,7 +1756,7 @@
 			"\t* Creates a sorcery instance with a test object\n"
 			"\t* Creates a test object with an id of test\n"
 			"\t* Pushes the test object into the memory cache\n"
-			"\t* Confirms that the test object is in the cache\n";
+			"\t* Confirms that the test object is in the cache";
 		return AST_TEST_NOT_RUN;
 	case TEST_EXECUTE:
 		break;
@@ -1838,7 +1838,7 @@
 			"\t* Confirms that the test object is in the cache\n"
 			"\t* Creates a new test object with the same id of test\n"
 			"\t* Pushes the new test object into the memory cache\n"
-			"\t* Confirms that the new test object has replaced the old one\n";
+			"\t* Confirms that the new test object has replaced the old one";
 		return AST_TEST_NOT_RUN;
 	case TEST_EXECUTE:
 		break;
@@ -1930,7 +1930,7 @@
 			"\t* Pushes the test object into the memory cache\n"
 			"\t* Confirms that the test object is in the cache\n"
 			"\t* Deletes the test object from the cache\n"
-			"\t* Confirms that the test object is no longer in the cache\n";
+			"\t* Confirms that the test object is no longer in the cache";
 		return AST_TEST_NOT_RUN;
 	case TEST_EXECUTE:
 		break;
@@ -2054,7 +2054,7 @@
 			"\t* Deletes charlie from the memory cache\n"
 			"\t* Confirms that only bob is in the memory cache\n"
 			"\t* Pushes alice into the memory cache\n"
-			"\t* Confirms that bob and alice are in the memory cache\n";
+			"\t* Confirms that bob and alice are in the memory cache";
 		return AST_TEST_NOT_RUN;
 	case TEST_EXECUTE:
 		break;
@@ -2169,7 +2169,7 @@
 			"\t* Creates a memory cache with a maximum object lifetime of 5 seconds\n"
 			"\t* Pushes 10 objects into the memory cache\n"
 			"\t* Waits (up to) 10 seconds for expiration to occur\n"
-			"\t* Confirms that the objects have been removed from the cache\n";
+			"\t* Confirms that the objects have been removed from the cache";
 		return AST_TEST_NOT_RUN;
 	case TEST_EXECUTE:
 		break;
@@ -2384,7 +2384,7 @@
 			"\t\t* Retrieve the stale cached object\n"
 			"\t\t* Ensure that the stale object retrieved is the same as the fresh one from earlier\n"
 			"\t\t* Wait for the cache to update with new data\n"
-			"\t\t* Ensure that new data in the cache matches backend data\n";
+			"\t\t* Ensure that new data in the cache matches backend data";
 		return AST_TEST_NOT_RUN;
 	case TEST_EXECUTE:
 		break;

-- 
To view, visit https://gerrit.asterisk.org/869
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ide519fbeba89f413c733446c5ff7b224fc4ce840
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Matt Jordan <mjordan at digium.com>



More information about the asterisk-code-review mailing list