[Asterisk-code-review] ARI: Added new functionality to load a single module. (asterisk[master])

[Benjamin Keith Ford]

Benjamin Keith Ford has posted comments on this change.

Change subject: ARI: Added new functionality to load a single module.
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.asterisk.org/#/c/814/2/rest-api/api-docs/asterisk.json
File rest-api/api-docs/asterisk.json:

Line 71: 							"reason": "Module could not be loaded."
> Except that it does not, at least not really. 
That may be the only 409 it will receive, hence the elaboration within the json file; I'm not sure. However, I will have to return 409s for different reasons, which I specify in resource_asterisk.c. This review also needs to be updated (my bad!), as the review on 13 always gets updated first.
I could potentially add all the reasons in the asterisk.json file, but I feel that since the code itself will tell you why it failed to load, a general reason (why the 409 is returned, a module load failure) is the appropriate content here. I could also be wrong though.


-- 
To view, visit https://gerrit.asterisk.org/814
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9e05d5b8c5c666ecfef341504f9edc1aa84fda33
Gerrit-PatchSet: 2
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Ashley Sanders <asanders at digium.com>
Gerrit-Reviewer: Benjamin Keith Ford <bford at digium.com>
Gerrit-HasComments: Yes