[Asterisk-code-review] bridge native rtp.c: Don't start native RTP bridging after a... (asterisk[13])

[Richard Mudgett]

Richard Mudgett has posted comments on this change.

Change subject: bridge_native_rtp.c: Don't start native RTP bridging after attended transfer.
......................................................................


Patch Set 1: Code-Review-1

(3 comments)

https://gerrit.asterisk.org/#/c/855/1//COMMIT_MSG
Commit Message:

Line 30: This allows the frame hook to
       : determine whether it has been detached as a field in the native RTP
       : bridge data is set when it has been.
Awkward sentence


https://gerrit.asterisk.org/#/c/855/1/bridges/bridge_native_rtp.c
File bridges/bridge_native_rtp.c:

Line 290: 			} else if ((f->subclass.integer == AST_CONTROL_UNHOLD) || (f->subclass.integer == AST_CONTROL_UPDATE_RTP_PEER)) {
Extra long line


Line 423: 		.destroy_cb = native_rtp_framehook_destroy,
Why not just use __ao2_cleanup() ?


-- 
To view, visit https://gerrit.asterisk.org/855
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I13a73186a05f4e5a764f81e5cd0ccec1ed1891d2
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes