[Asterisk-code-review] translate: Re-enables native Packet-Loss Concealment (PLC) f... (asterisk[master])

[Joshua Colp]

Joshua Colp has posted comments on this change.

Change subject: translate: Re-enables native Packet-Loss Concealment (PLC) for iLBC and Speex.
......................................................................


Patch Set 4: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/1820/4/main/translate.c
File main/translate.c:

Line 587: 		struct ast_frame *missed = ast_malloc(sizeof(*missed));
The standard way of doing this is defining a frame on the stack and then using ast_frdup to duplicate it. This ensures that a cached frame can be reused, that it is sized correctly, and that it is initialized completely.


-- 
To view, visit https://gerrit.asterisk.org/1820
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibfcf0670e094e9718d82fd9920f1fb2dae122006
Gerrit-PatchSet: 4
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-HasComments: Yes