[Asterisk-code-review] chan sip.c: Validation on module reload (asterisk[master])

[Rodrigo Ramirez Norambuena]

Rodrigo Ramirez Norambuena has posted comments on this change.

Change subject: chan_sip.c: Validation on module reload
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.asterisk.org/#/c/1126/1/channels/chan_sip.c
File channels/chan_sip.c:

Line 33156: 	if (sip_reload(0, 0, NULL) == CLI_SUCCESS) {
          : 		return AST_MODULE_LOAD_SUCCESS;
          : 	}
          : 	return AST_MODULE_LOAD_DECLINE;
> This should just become:
Yes, sip_reload never fail. I understand your point. 

Used sip_reload() dont have errors controls, reload is a "recover" for sip_reload, because will not used reload_config instance of sip_reload()?


-- 
To view, visit https://gerrit.asterisk.org/1126
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I41215877fb2cfc589e0d4d464000cf6825f4d7fb
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Rodrigo Ramirez Norambuena <a at rodrigoramirez.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: Rodrigo Ramirez Norambuena <a at rodrigoramirez.com>
Gerrit-HasComments: Yes