[Asterisk-code-review] SIP: Rewrite tcpauthlimit test in Python (testsuite[master])

[Jonathan Rose]

Jonathan Rose has posted comments on this change.

Change subject: SIP: Rewrite tcpauthlimit test in Python
......................................................................


Patch Set 4:

(1 comment)

https://gerrit.asterisk.org/#/c/1055/4/tests/channels/SIP/tcpauthlimit/tcpauthlimit.py
File tests/channels/SIP/tcpauthlimit/tcpauthlimit.py:

Line 14: sys.path.append("tests/channels/SIP/tcpauthlimit/sipp_client_scenario")
       : sys.path.append("tests/channels/SIP/tcpauthlimit/tcp_client_scenario")
       : 
       : from tcp_scenario import TcpClientScenario
       : from sipp_scenario import SIPpScenarioWrapper
I mentioned this when we were going over the test the other day, but what I don't like about this is that you have the generic test class including stuff that is in folders for specific tests. It works, but it's kludgy.

If you anticipate that there is a need to use these classes in further tests, move tcp_scenario.py and sipp_scenario.py up into the tcpauthlimit folder and do away with these appends. I personally think that approach would be fine. If you believe that each is going to remain test specific and really don't want the classes to be moved up, find a way to define the classes/functions you need strictly in yaml rather than relying on including from the specific tests.


-- 
To view, visit https://gerrit.asterisk.org/1055
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ica28ba0ca7ae92b3546da4cd23458f289c111d36
Gerrit-PatchSet: 4
Gerrit-Project: testsuite
Gerrit-Branch: master
Gerrit-Owner: Ashley Sanders <asanders at digium.com>
Gerrit-Reviewer: Ashley Sanders <asanders at digium.com>
Gerrit-Reviewer: Jonathan Rose <jrose at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-HasComments: Yes