[Asterisk-code-review] app queue.c: Fix error checking in QUEUE MEMBER() read. (asterisk[13])

[Ashley Sanders]

Ashley Sanders has posted comments on this change.

Change subject: app_queue.c: Fix error checking in QUEUE_MEMBER() read.
......................................................................


Patch Set 2: Code-Review-1

(3 comments)

https://gerrit.asterisk.org/#/c/1106/2/apps/app_queue.c
File apps/app_queue.c:

Line 8079: 
> This had caused me some concern in that it might have been a desired featur
I agree and that was an awkward implementation. Good catch.


Line 8097: 
         : 
         : 
Why was this log message changed from the original? (Maybe it's superfluous at the point of someone looking at the log which makes sense to remove it.)


Line 8015: if (ast_strlen_zero(interface)) {
         : 		ast_log(LOG_ERROR, "QUEUE_MEMBER: Missing required interface argument.\n");
         : 		return NULL;
         : 	}
         : 
         : 	m = interface_exists(q, interface);
         : 	if (!m) {
         : 		ast_log(LOG_ERROR, "Queue member interface '%s' not in queue '%s'.\n",
         : 			interface, q->name);
         : 	}
I think we should be consistent as much as possible when outputting log messages. In other words, both of these messages (I think) should be prefaced either with QUEUE_MEMBER: or Queue member. It really makes no difference to me. The QUEUE_MEMBER: one may be easier for someone to spot in a log, though.


-- 
To view, visit https://gerrit.asterisk.org/1106
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7294e13d27875851c2f4ef6818adba507509d224
Gerrit-PatchSet: 2
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Ashley Sanders <asanders at digium.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Matt Jordan <mjordan at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: Scott Griepentrog <sgriepentrog at digium.com>
Gerrit-HasComments: Yes