[Asterisk-code-review] pbx/dialplan reload: Add hints to the dialplan reload test (testsuite[master])

Ashley Sanders asteriskteam at digium.com
Thu Apr 30 21:28:28 CDT 2015


Ashley Sanders has posted comments on this change.

Change subject: pbx/dialplan_reload: Add hints to the dialplan reload test
......................................................................


Patch Set 2:

(2 comments)

https://gerrit.asterisk.org/#/c/310/2/tests/pbx/dialplan_reload/run-test
File tests/pbx/dialplan_reload/run-test:

Line 26:         TestCase.__init__(self)
I would probably update this to use the 'super' construct, _even though technically it is not part of this change_.


Line 32:         TestCase.run(self)
Same here =)


-- 
To view, visit https://gerrit.asterisk.org/310
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic8f369aa552cad8e53b790596b1eafc0b5ea1b16
Gerrit-PatchSet: 2
Gerrit-Project: testsuite
Gerrit-Branch: master
Gerrit-Owner: Matt Jordan <mjordan at digium.com>
Gerrit-Reviewer: Ashley Sanders <asanders at digium.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-HasComments: Yes



More information about the asterisk-code-review mailing list