[Asterisk-code-review] ARI: Fix missing dependencies. (asterisk[master])

Mark Michelson asteriskteam at digium.com
Wed Apr 29 15:17:09 CDT 2015


Mark Michelson has posted comments on this change.

Change subject: ARI: Fix missing dependencies.
......................................................................


Patch Set 2:

> This patch is slightly different than for 13 because of the
 > MOD_ADD_C macro used to add sources.  An additional rule was added
 > in MOD_ADD_SOURCE instead of modifying res/ari.make and
 > rest-api-templates/ari.make.mustache.
 > 
 > Is this something that should be added to the commit message for
 > master?

I don't think so. The commit message doesn't go into specifics, so as long as the same overall goal is being achieved by both the 13 and the master changes, then I think the same commit message for both is fine.

-- 
To view, visit https://gerrit.asterisk.org/276
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8e07fe7e81fedacb87232f2b6f8b5f47927b4153
Gerrit-PatchSet: 2
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-HasComments: No



More information about the asterisk-code-review mailing list