[Asterisk-code-review] chan pjsip: Creating Channel Causes Asterisk to Crash When D... (asterisk[master])

[Joshua Colp]

Joshua Colp has posted comments on this change.

Change subject: chan_pjsip: Creating Channel Causes Asterisk to Crash When Duplicate AOR             Sections Exist in pjsip.conf
......................................................................


Patch Set 3: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/254/3//COMMIT_MSG
Commit Message:

Line 10: This patch modifies the current loading strategy to consider the entire
       : pjsip configuration as invalid if duplicate sections (e.g. sections
       : containing the same [id/type]) are defined in pjsip.conf. If a duplicate
       : section is encountered during load, the configuration for the given type
       : is rejected and destroyed, an error message is logged and the load
       : processing for the given stops.
This commit message now contradicts itself slightly. You mention considering the entire pjsip (PJSIP) configuration invalid and reading it makes it seem as though that means everything - however in your clarification you specify only the given type.

As well I think I will go ahead and ask you to modify this to include both PJSIP and res_sorcery_config in the description. You didn't really make it so PJSIP did this, you made it so res_sorcery_config did it. ^_^


-- 
To view, visit https://gerrit.asterisk.org/254
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I35090ca4cd40f1f34881dfe701a329145c347aef
Gerrit-PatchSet: 3
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Ashley Sanders <asanders at digium.com>
Gerrit-Reviewer: Ashley Sanders <asanders at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Matt Jordan <mjordan at digium.com>
Gerrit-HasComments: Yes