[Asterisk-code-review] Update configure.ac/Makefile for clang (asterisk[13])

Diederik de Groot asteriskteam at digium.com
Sat Apr 25 04:45:57 CDT 2015


Diederik de Groot has posted comments on this change.

Change subject: Update configure.ac/Makefile for clang
......................................................................


Patch Set 7:

@Corey: Thanks for your review.

I see how this would cause an issue. Your method of checking would work and makes sense. I opted to use the previous RAII check (though), which detects the used compiler by testing a builtin define (__clang__). That should work in either even in cases like CC="ccache llvm-gcc" and CC="ccache clang".

If we need to change the detection method as proposed by you, i will do so.

-- 
To view, visit https://gerrit.asterisk.org/157
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I12ea29d3bda2254ad3908e279b7effbbac6a97cb
Gerrit-PatchSet: 7
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Diederik de Groot <dkgroot at talon.nl>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Diederik de Groot <dkgroot at talon.nl>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Matt Jordan <mjordan at digium.com>
Gerrit-HasComments: No



More information about the asterisk-code-review mailing list