[Asterisk-code-review] app confbridge: Default the template option to a compatible ... (asterisk[13])

[Richard Mudgett]

Richard Mudgett has posted comments on this change.

Change subject: app_confbridge: Default the template option to a compatible default profile.
......................................................................


Patch Set 4: Code-Review-1

(3 comments)

https://gerrit.asterisk.org/#/c/243/4/apps/confbridge/conf_config_parser.c
File apps/confbridge/conf_config_parser.c:

Line 1040: 		}
         : 
         : 		if (!b_data->b_usable) {
         : 			set_template_defaults(b_data);
         : 		}
         : 
         : 		if (!aco_process_var(&bridge_type, "dialplan", &tmpvar, &b_data->b_profile)) {
Needs to set bridge defaults in the "clear" else clause only.


Line 1056: 		}
         : 
         : 		if (!b_data->u_usable) {
         : 			set_template_defaults(b_data);
         : 		}
         : 
         : 		if (!aco_process_var(&user_type, "dialplan", &tmpvar, &b_data->u_profile)) {
Needs to set user defaults in the "clear" else clause only.


Line 1078: 		}
         : 
         : 		if (!b_data->m_usable) {
         : 			set_template_defaults(b_data);
         : 		}
         : 
         : 		if (!aco_process_var(&menu_type, "dialplan", &tmpvar, b_data->menu)) {
Needs to set menu defaults in the "clear" else clause only.


-- 
To view, visit https://gerrit.asterisk.org/243
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1bd6e94b38701ac2112d842db68de63d46f60e0a
Gerrit-PatchSet: 4
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes