[Asterisk-code-review] Astobj2: Ensure all calls to adjust lock pass a valid object. (asterisk[13])

[Richard Mudgett]

Richard Mudgett has posted comments on this change.

Change subject: Astobj2: Ensure all calls to __adjust_lock pass a valid object.
......................................................................


Patch Set 1: Code-Review-1

(2 comments)

https://gerrit.asterisk.org/#/c/221/1/main/astobj2_container.c
File main/astobj2_container.c:

Line 513: 	if (!is_ao2_object(iter->c)) {
        : 		ast_assert(0);
I think the same error message is needed here about an invalid container.


https://gerrit.asterisk.org/#/c/221/1/main/astobj2_private.h
File main/astobj2_private.h:

Line 48: /* user_data must be a valid AO2 object */
The comment is not needed as it is redundant.  The doxygen comment is where the function is defined.


-- 
To view, visit https://gerrit.asterisk.org/221
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I669100f87937cc3f867cec56a27ae9c01292908f
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes