[Asterisk-code-review] jira-release-update: Update script to support Git (repotools[master])

[Mark Michelson]

Mark Michelson has posted comments on this change.

Change subject: jira-release-update: Update script to support Git
......................................................................


Patch Set 1: Code-Review-1

(2 comments)

https://gerrit.asterisk.org/#/c/180/1/jira-release-update.py
File jira-release-update.py:

Line 61:             except Exception:
       :                 print "Could not get issue {0}".format(issue_id)
       :                 pbar.update(i + 1)
       :                 continue
>From what I understand, pbar is supposed to update for each log message processed. This continue pertains to the inner loop "for issue_obj in issues" . So you probably shouldn't be updating pbar here.


Line 75:                 except Exception:
       :                     print "Could not handle versions for {0}".format(issue_id)
       :                     pbar.update(i + 1)
       :                     continue
Another place not to update pbar.


-- 
To view, visit https://gerrit.asterisk.org/180
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I82091b9213f607cdf4e78ffc580508a00c405ca4
Gerrit-PatchSet: 1
Gerrit-Project: repotools
Gerrit-Branch: master
Gerrit-Owner: Matt Jordan <mjordan at digium.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-HasComments: Yes