[Asterisk-code-review] res pjsip mwi: Send unsolicited MWI NOTIFY on startup and wh... (asterisk[master])
George Joseph
asteriskteam at digium.com
Tue Apr 21 09:38:20 CDT 2015
George Joseph has posted comments on this change.
Change subject: res_pjsip_mwi: Send unsolicited MWI NOTIFY on startup and when endpoint registers.
......................................................................
Patch Set 1: Code-Review-1
(3 comments)
https://gerrit.asterisk.org/#/c/176/1/res/res_pjsip_mwi.c
File res/res_pjsip_mwi.c:
Line 238: sub->aors = ast_strdup(endpoint->aors);
Does this get freed somewhere?
Line 938: RAII_VAR(struct ao2_container *, mwi_subscriptions, ao2_global_obj_ref(unsolicited_mwi), ao2_cleanup);
Need RAII_VAR?
Line 958: RAII_VAR(struct ao2_container *, mwi_subscriptions, ao2_global_obj_ref(unsolicited_mwi), ao2_cleanup);
Need RAII_VAR?
--
To view, visit https://gerrit.asterisk.org/176
To unsubscribe, visit https://gerrit.asterisk.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I043f20230227e91218f18a82c7d5bb2aa62b1d58
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: George Joseph <george.joseph at fairview5.com>
Gerrit-HasComments: Yes
More information about the asterisk-code-review
mailing list