[Asterisk-code-review] pjsip options: Fix non-qualified contacts showing as unavai... (asterisk[13])

George Joseph asteriskteam at digium.com
Mon Apr 20 17:21:20 CDT 2015


George Joseph has posted comments on this change.

Change subject: pjsip_options:  Fix non-qualified contacts showing as unavailable
......................................................................


Patch Set 4:

> (1 comment)

I thought it would be clearer, especially thinking about reloads when qualify_frequency is changed to/from 0.  .  This way, the update observer is always called when there's a status change instead of created/deleted/updated depending on the situation.  It also gives those retrieving the status a more positive response.  You can now ast_assert(contact_status).  If it's valid, you can use ->status.

-- 
To view, visit https://gerrit.asterisk.org/147
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifcbc01533ce57f0e4e584b89a395326e098b8fe7
Gerrit-PatchSet: 4
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: George Joseph <george.joseph at fairview5.com>
Gerrit-Reviewer: George Joseph <george.joseph at fairview5.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Matt Jordan <mjordan at digium.com>
Gerrit-HasComments: No



More information about the asterisk-code-review mailing list