[Asterisk-code-review] Moved clang / RAII specific check to their own files Added c... (asterisk[13])

Matt Jordan asteriskteam at digium.com
Mon Apr 20 12:20:28 CDT 2015


Matt Jordan has posted comments on this change.

Change subject: Moved clang / RAII specific check to their own files Added clang warning suppressions to Makefile.rules Adapted configure.ac Ran bootstap
......................................................................


Patch Set 1: Code-Review-1

(2 comments)

https://gerrit.asterisk.org/#/c/157/1//COMMIT_MSG
Commit Message:

Line 6: 
      : Moved clang / RAII specific check to their own files
      : Added clang warning suppressions to Makefile.rules
      : Adapted configure.ac
      : Ran bootstap
The same comment about properly formatting the commit message and following the commit message guidelines applies here as well.

See https://wiki.asterisk.org/wiki/display/AST/Commit+Messages


https://gerrit.asterisk.org/#/c/157/1/autoconf/ast_check_strsep_array_bounds.m4
File autoconf/ast_check_strsep_array_bounds.m4:

Line 1: dnl "https://llvm.org/bugs/show_bug.cgi?id=11536" / "https://reviewboard.asterisk.org/r/4546/"
      : AC_DEFUN([AST_CHECK_STRSEP_ARRAY_BOUNDS], [
Please provide a longer description of what this macro does and why it is needed.

Referencing URLs is not a long term solution: pages tend to die and/or move away.


-- 
To view, visit https://gerrit.asterisk.org/157
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I12ea29d3bda2254ad3908e279b7effbbac6a97cb
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Diederik de Groot <dkgroot at talon.nl>
Gerrit-Reviewer: George Joseph <george.joseph at fairview5.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Matt Jordan <mjordan at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes



More information about the asterisk-code-review mailing list