[Asterisk-code-review] Change in testsuite[master]: pbx/callerid_match: Skip test.

Corey Farrell (Code Review) asteriskteam at digium.com
Thu Apr 16 15:55:45 CDT 2015


Corey Farrell has uploaded a new change for review.

  https://gerrit.asterisk.org/137

Change subject: pbx/callerid_match: Skip test.
......................................................................

pbx/callerid_match: Skip test.

This change fixes a bug in the test that leaves a channel open.  Unfortunately
there is an unresolved bug in Asterisk that causes a crash when this test
shuts down.  Set this test to skip due to ASTERISK-24774.

ASTERISK-24774 #comment Disable effected testsuite.

Change-Id: I0a1b421280d6d87a26fba01cc1005267aa3eab4c
---
M tests/pbx/callerid_match/run-test
M tests/pbx/callerid_match/test-config.yaml
2 files changed, 3 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.asterisk.org:29418/testsuite refs/changes/37/137/1

diff --git a/tests/pbx/callerid_match/run-test b/tests/pbx/callerid_match/run-test
index 2e0e27a..bfc692d 100755
--- a/tests/pbx/callerid_match/run-test
+++ b/tests/pbx/callerid_match/run-test
@@ -49,9 +49,10 @@
     def fastagi_connect(self, agi):
         LOGGER.info("sample%s.call file executed." % (self.test))
 
+        reactor.callLater(2, agi.finish)
         if self.test < self.num_tests:
             self.launch_test()
-        else: self.finalize()
+        else: reactor.callLater(4, self.finalize)
 
     def move_file(self, i):
         LOGGER.info("Moving the sample%s.call file to the spool dir..." % (i))
diff --git a/tests/pbx/callerid_match/test-config.yaml b/tests/pbx/callerid_match/test-config.yaml
index f28eb1f..e873173 100644
--- a/tests/pbx/callerid_match/test-config.yaml
+++ b/tests/pbx/callerid_match/test-config.yaml
@@ -1,4 +1,5 @@
 testinfo:
+    skip: 'See ASTERISK-24774'
     summary:     'Test callerid pattern matching'
     description: 'Sends calls into test context with various callerid'
 

-- 
To view, visit https://gerrit.asterisk.org/137
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I0a1b421280d6d87a26fba01cc1005267aa3eab4c
Gerrit-PatchSet: 1
Gerrit-Project: testsuite
Gerrit-Branch: master
Gerrit-Owner: Corey Farrell <git at cfware.com>



More information about the asterisk-code-review mailing list