[Asterisk-code-review] Change in asterisk[13]: bridge.c: NULL app causes crash during attended transfer

[Scott Griepentrog (Code Review)]

Scott Griepentrog has posted comments on this change.

Change subject: bridge.c: NULL app causes crash during attended transfer
......................................................................


Patch Set 4: Code-Review+1

(1 comment)

https://gerrit.asterisk.org/#/c/133/4/main/bridge.c
File main/bridge.c:

Line 4480: Since there is a race condition that makes it possible for the app to be NULL,
         : 	 * when retrieved later, get the app prior to transferring. It should have an
         : 	 * associated app when getting it here, but if it doesn't just use "unknown".
The entire paragraph is a bit awkward, even without the comma.  Suggest:

Race condition makes it possible for app to be NULL, so
get the app prior to transferring with a fallback of
"unknown".


-- 
To view, visit https://gerrit.asterisk.org/133
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5134b84c4524906d8148817719d76ffb306488ac
Gerrit-PatchSet: 4
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: Scott Griepentrog <sgriepentrog at digium.com>
Gerrit-HasComments: Yes