[Asterisk-code-review] Change in testsuite[master]: pjsip/options: Add tests for qualify_timeout and max_initia...
Joshua Colp (Code Review)
asteriskteam at digium.com
Wed Apr 15 07:18:30 CDT 2015
Joshua Colp has posted comments on this change.
Change subject: pjsip/options: Add tests for qualify_timeout and max_initial_qualify_time
......................................................................
Patch Set 2: Code-Review-1
(6 comments)
https://gerrit.asterisk.org/#/c/92/2//COMMIT_MSG
Commit Message:
Line 9: Renamed the original test to 'auth' since it's putpose was to make sure
purpose
https://gerrit.asterisk.org/#/c/92/2/tests/channels/pjsip/qualify/basic/test-config.yaml
File tests/channels/pjsip/qualify/basic/test-config.yaml:
Line 49:
red blob
https://gerrit.asterisk.org/#/c/92/2/tests/channels/pjsip/qualify/max_initial_qualify_time/test-config.yaml
File tests/channels/pjsip/qualify/max_initial_qualify_time/test-config.yaml:
Line 6: reactor timeout. If it isn't then max_initial_qualify_time didn't work.
trailing whitespace
Line 50:
red blob
https://gerrit.asterisk.org/#/c/92/2/tests/channels/pjsip/qualify/qualify_timeout/test-config.yaml
File tests/channels/pjsip/qualify/qualify_timeout/test-config.yaml:
Line 5: contact and verify that the contact is marked Unavailable.
trailing whitespace
Line 38:
red blob
--
To view, visit https://gerrit.asterisk.org/92
To unsubscribe, visit https://gerrit.asterisk.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id37260a9f6b9927fdd90bef73d43a97ce2445fa1
Gerrit-PatchSet: 2
Gerrit-Project: testsuite
Gerrit-Branch: master
Gerrit-Owner: George Joseph <george.joseph at fairview5.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-HasComments: Yes
More information about the asterisk-code-review
mailing list