[Asterisk-code-review] Change in asterisk[13]: res_pjsip: Add global option to limit the maximum time for i...

[Joshua Colp (Code Review)]

Joshua Colp has posted comments on this change.

Change subject: res_pjsip: Add global option to limit the maximum time for initial qualifies
......................................................................


Patch Set 3: Code-Review-1

(4 comments)

I think this should also include additions to pjsip.conf.sample

https://gerrit.asterisk.org/#/c/45/3//COMMIT_MSG
Commit Message:

Line 18: your contacts are initialy, ransomly qualified within say 30 seconds but still
randomly


Line 27: Testing Done:
       : Tested in my own pbx with 15 endpoints.
       : If max_initial_qualify_time is > 0 and < qualify_time, it's used, otherwise
       : qualify_timeout is used.
       : 
       : Testsuite test forthcoming.
I don't think these sort of comments belong here, since this is the commit message itself.


https://gerrit.asterisk.org/#/c/45/3/CHANGES
File CHANGES:

Line 40:    sets the The maximum amount of time from startup that qualifies should be
sets the maximum amount


https://gerrit.asterisk.org/#/c/45/3/res/res_pjsip.c
File res/res_pjsip.c:

Line 1230: 					<synopsis>The maximum amount of time from startup that qualifies should be attempted on all contacts.</synopsis>
I'd clarify that this value has to be less than the qualify interval.


-- 
To view, visit https://gerrit.asterisk.org/45
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib80498aa1ea9923277bef51d6a9015c9c79740f4
Gerrit-PatchSet: 3
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: George Joseph <george.joseph at fairview5.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes