[Asterisk-code-review] Change in asterisk[master]: astobj2: Add support for weakproxy objects.
Richard Mudgett (Code Review)
asteriskteam at digium.com
Mon Apr 13 17:36:02 CDT 2015
Richard Mudgett has posted comments on this change.
Change subject: astobj2: Add support for weakproxy objects.
......................................................................
Patch Set 1:
(2 comments)
Minor nits to tryout gerrit.
https://gerrit.asterisk.org/#/c/56/1/main/astobj2.c
File main/astobj2.c:
Line 804: struct astobj2 *weakproxy_internal = INTERNAL_OBJ(weakproxy);
Nit. A blank line after variable declarations is nice.
https://gerrit.asterisk.org/#/c/56/1/tests/test_astobj2_weaken.c
File tests/test_astobj2_weaken.c:
Line 55: int *i = data;
Same here
--
To view, visit https://gerrit.asterisk.org/56
To unsubscribe, visit https://gerrit.asterisk.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib9f73c02262488d314d9d9d62f58165b9ec43c67
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes
More information about the asterisk-code-review
mailing list