[asterisk-bugs] [JIRA] (DAHLIN-356) Compilation fails on 4.13

[Sean Darcy (JIRA)]

    [ https://issues.asterisk.org/jira/browse/DAHLIN-356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=239666#comment-239666 ] 

Sean Darcy commented on DAHLIN-356:
-----------------------------------

Right you are. Used the git master, and your v3 patch. defined but not used fixed. memset warnings remain.

There are two other warnings. I tried to see if I could actually be helpful, but couldn't be certain enough of the underlying logic to propose a patch.

  CC [M]  /home/asterisk/rpmbuild/BUILD/dahdi-linux-master/drivers/dahdi/voicebus/GpakApi.o
/home/asterisk/rpmbuild/BUILD/dahdi-linux-master/drivers/dahdi/voicebus/GpakApi.c: In function 'gpakWriteSystemParms':
/home/asterisk/rpmbuild/BUILD/dahdi-linux-master/drivers/dahdi/voicebus/GpakApi.c:1648:22: warning: 'MsgBuffer[1]' may be used uninitialized in this function [-Wmaybe-uninitialized]
         MsgBuffer[1] |= DTMF_UPDATE_MASK;

and
  CC [M]  /home/asterisk/rpmbuild/BUILD/dahdi-linux-master/drivers/dahdi/xpp/card_fxs.o
/home/asterisk/rpmbuild/BUILD/dahdi-linux-master/drivers/dahdi/xpp/card_fxs.c: In function 'FXS_card_ioctl':
/home/asterisk/rpmbuild/BUILD/dahdi-linux-master/drivers/dahdi/xpp/card_fxs.c:1344:17: warning: increment of a boolean expression [-Wbool-operation]
    if (!notified++)
                 ^~



> Compilation fails on 4.13
> -------------------------
>
>                 Key: DAHLIN-356
>                 URL: https://issues.asterisk.org/jira/browse/DAHLIN-356
>             Project: DAHDI-Linux
>          Issue Type: Bug
>      Security Level: None
>         Environment: Kernel >= 4.13
>            Reporter: Jean-Denis Girard
>            Assignee: Shaun Ruffell
>            Severity: Blocker
>         Attachments: dev_attrs_groups.patch, dev_attrs_groups-v2.patch, dev_attrs_groups-v3.patch
>
>
> dev_attrs was removed from struct bus_type on kernel 4.13, need to convert to dev_groups, see http://lkml.iu.edu/hypermail/linux/kernel/1706.0/04578.html.
> I made a patch and sent a pull request on github.



--
This message was sent by Atlassian JIRA
(v6.2#6252)