Apologies for bringing up an old thread but I had hoped it would have continued on it's own and I take issue with Xorcom's code getting included and causing issue after issue.<br><br>Kevin said "I believe that <span class="nfakPe">redfone</span> did submit their driver for inclusion into<br>
Zaptel, and that it was rejected for the reasons you mentioned (coding<br>
guidelines and code quality). We do not accept code that does not<br>
conform to at least reasonable standards of quality, because doing so<br>
would allow the code base to deteriorate and increase everyone else's<br>
support burden."<br><br>Joeseph has a different story. I would like to know what the "REAL" reason is for not including his code.<br><br>I would also like to know why xpp (Xorcom) stuff has it's own Zaptel release bug fixes (and I assume DAHDI as well) because it is released buggy and won't build without hacking source code. By default, I do make menuselect and remove xpp now because I don't feel like fixing buggy Xorcom code.<br>
<br>I only mention this because of Kevin's statements about not meeting coding guidlines. I would assume part of coding guidelines is the ability to build from source provided dependencies are met, without crapping out.<br>
<br>Kevin Flemming "We do not accept code that does not<br>
conform to at least reasonable standards of quality, because doing so<br>
would allow the code base to deteriorate and increase everyone else's<br>
support burden."<br><br>-- <br>Thanks,<br>Steve Totaro <br>+18887771888 (Toll Free)<br>+12409381212 (Cell)<br>+12024369784 (Skype)<br><br><div class="gmail_quote">On Fri, Oct 31, 2008 at 6:46 PM, Joseph Benden <span dir="ltr"><<a href="mailto:joe@thrallingpenguin.com">joe@thrallingpenguin.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">Hello all,<br>
<br>
I am the author and maintainer of TDMoE-Multiframe.<br>
<br>
[please do not read the following as an attack, but rather simple<br>
comments.]<br>
<br>
The code did not have any major coding or quality issues, but rather<br>
had licensing issues because I had an old license on file and Digium<br>
switching to a newer license (which I was unaware of the change), I<br>
submitted the new license (which was approved) and now the code sits<br>
and rots in the tracker, along with the new DAHDI implementation of<br>
the driver.<br>
<br>
This is not unusual around this part of the open source world. I've<br>
had other patches and contributions that have experienced the same fate.<br>
<br>
I do deal (program, patch, etc.) with other open source software and<br>
do not have this much trouble in having the maintainers accept the<br>
code. I assume their projects are just as widespread (proftpd, clamav,<br>
freebsd), so using the number of outstanding patches as a reason for<br>
not accepting them is not convincing to me.<br>
<br>
Because of the difficulties in having Asterisk accept the Solaris<br>
community (read as: accept high availability patches and Solaris/<br>
OpenSolaris specific patches), I had to fork the project which then<br>
became SolarisVoip.com<br>
<br>
I am trying to work towards updating SolarisVoip.com to 1.6 (including<br>
the DAHDI drivers), but am very hesitant. Would Digium finally agree<br>
to working with me in possibly having my yet-to-be patches for<br>
Solaris? How about a branch/module for the Solaris specific DAHDI<br>
drivers? I tried in the past at working with Digium, but was always<br>
pushed to the side and forgotten (even though some within Digium<br>
seemed happy to work with me.)<br>
<br>
Comments, suggestions, or ideas welcomed!<br>
<br>
Best Regards,<br>
Joseph Benden<br>
<br>
.--.<br>
|o_o |<br>
|:_/ |<br>
// \ \<br>
(| | )<br>
/'\_ _/`\<br>
\___)=(___/<br>
<a href="http://www.ThrallingPenguin.com/" target="_blank">http://www.ThrallingPenguin.com/</a><br>
--------------------------------<br>
We design, develop, and extend<br>
software technologies for the<br>
most demanding business<br>
applications, as well as<br>
offer VoIP Consulting<br>
services.<br>
<div><div></div><div class="Wj3C7c"><br>
<br>
<br>
On Oct 31, 2008, at 6:21 PM, Kevin P. Fleming wrote:<br>
<br>
> Kevin P. Fleming wrote:<br>
>> Bill Michaelson wrote:<br>
>><br>
>>> ztd-ethmf.c<br>
>><br>
>> As I said, that driver has been part of Zaptel, so could not have<br>
>> been<br>
>> removed.<br>
><br>
> Correction: it was in Zaptel SVN for a very short time, it had been<br>
> committed without proper code review. It was removed quickly<br>
> thereafter,<br>
> and was never part of an Zaptel release.<br>
><br>
> --<br>
> Kevin P. Fleming<br>
> Director of Software Technologies<br>
> Digium, Inc. - "The Genuine Asterisk Experience" (TM)<br>
><br>
> _______________________________________________<br>
> --Bandwidth and Colocation Provided by <a href="http://www.api-digital.com--" target="_blank">http://www.api-digital.com--</a><br>
><br>
> asterisk-biz mailing list<br>
> To UNSUBSCRIBE or update options visit:<br>
> <a href="http://lists.digium.com/mailman/listinfo/asterisk-biz" target="_blank">http://lists.digium.com/mailman/listinfo/asterisk-biz</a><br>
><br>
<br>
<br>
_______________________________________________<br>
--Bandwidth and Colocation Provided by <a href="http://www.api-digital.com--" target="_blank">http://www.api-digital.com--</a><br>
<br>
asterisk-biz mailing list<br>
To UNSUBSCRIBE or update options visit:<br>
<a href="http://lists.digium.com/mailman/listinfo/asterisk-biz" target="_blank">http://lists.digium.com/mailman/listinfo/asterisk-biz</a><br>
</div></div></blockquote></div><br><br clear="all"><br>