<html>
    <head>
        <meta charset="utf-8" />
        <meta name="viewport" content="width=device-width" />
        <style type="text/css">
        a:hover, a:focus { text-decoration: underline !important; }

        @media handheld, only screen and (max-device-width: 480px) {
            div, a, p, td, th, li, dt, dd {
                -webkit-text-size-adjust: auto;
            }
            small, small a {
                -webkit-text-size-adjust: 90%;
            }
            small[class=email-metadata] {
                -webkit-text-size-adjust: 93%;
                font-size: 12px;
            }

            table[id=email-wrap] > tbody > tr > td {
                padding: 2px !important;
            }
            table[id=email-wrap-inner] > tbody > tr > td {
                padding: 8px !important;
            }
            table[id=email-footer] td {
                padding: 8px 12px !important;
            }
            table[id=email-actions] td {
                padding-top: 0 !important;
            }
            table[id=email-actions] td.right {
                text-align: right !important;
            }
            table[id=email-actions] .email-list-item {
                display: block;
                margin: 1em 0 !important;
                word-wrap: normal !important;
            }
            span[class=email-list-divider] {
                display: none;
            }
            .commentsummary small[class=email-metadata] {
                display: block;
            }
            td.comment-avatar {
                padding: 8px 8px 0 8px !important;
            }
            .comment > td + td {
                padding: 8px 8px 8px 0 !important;
            }
        }

        </style>
    </head>
    <body style="font: 13px Arial, FreeSans, Helvetica, sans-serif; background: #f0f0f0; color: #505050">
        <table id="email-wrap" align="center" cellpadding="0" cellspacing="0" width="100%" style="margin: 0; border: 0; border-collapse: collapse; font-size: inherit; font-style: inherit; font-variant: inherit; font-weight: inherit; background: #f0f0f0; color: #505050">
            <tbody>
                <tr>
                    <td style="font: 13px Arial, FreeSans, Helvetica, sans-serif; text-align: left; vertical-align: top; padding: 16px">
                        <div id="title-status" class="successful" style="font: 13px Arial, FreeSans, Helvetica, sans-serif; padding: 8px 0; background: #5bad5b">
                            <table cellpadding="0" cellspacing="0" width="100%" style="margin: 0; border: 0; border-collapse: collapse; font-size: inherit; font-style: inherit; font-variant: inherit; font-weight: inherit; border-style: solid; border-width: 1px 0; table-layout: fixed; background: #393; border-color: #309130">
                                <tbody>
                                    <tr>
                                        <td id="title-status-icon" style="font: 13px Arial, FreeSans, Helvetica, sans-serif; text-align: left; vertical-align: top; padding: 8px 0 8px 8px; width: 24px"> <img src="http://bamboo.asterisk.org/images/iconsv3/plan_successful_16.png" alt="Successful" style="border: 0; height: 16px; width: 16px" /> </td>
                                        <td id="title-status-text" style="font: 13px Arial, FreeSans, Helvetica, sans-serif; text-align: left; vertical-align: top; font-size: 16px; padding: 8px; text-shadow: 1px 1px 1px #194c19; color: #fff"> <span class="build" style="font-weight: bold"> <a href="http://bamboo.asterisk.org/browse/ASTTEAM/" style="color: #326ca6; text-decoration: none; color: #fff">Asterisk - Team Branches</a> › <a href="http://bamboo.asterisk.org/browse/ASTTEAM-PIMPMYSIP/" style="color: #326ca6; text-decoration: none; color: #fff">Pimp My SIP</a> › <a href="http://bamboo.asterisk.org/browse/ASTTEAM-PIMPMYSIP-136/" style="color: #326ca6; text-decoration: none; color: #fff">#136</a> </span> <span class="status">was successful</span> </td>
                                    </tr>
                                </tbody>
                            </table>
                        </div>
                        <table id="email-wrap-inner" cellpadding="0" cellspacing="0" width="100%" style="margin: 0; border: 0; border-collapse: collapse; font-size: inherit; font-style: inherit; font-variant: inherit; font-weight: inherit; background: #fff; border: 1px solid #bbb; color: #000; border-top: 0">
                            <tbody>
                                <tr>
                                    <td style="font: 13px Arial, FreeSans, Helvetica, sans-serif; text-align: left; vertical-align: top; padding: 16px"> <p class="trigger" style="font: 13px Arial, FreeSans, Helvetica, sans-serif; margin: 16px 0 0 0; margin-top: 4px">Code has been updated by <a href="http://bamboo.asterisk.org/browse/author/root" style="color: #326ca6; text-decoration: none">root</a>.</p> <p class="tests-summary" style="font: 13px Arial, FreeSans, Helvetica, sans-serif; margin: 16px 0 0 0; margin-top: 4px"> All <strong>2</strong> jobs passed with <strong>208</strong> tests in total. </p>
                                        <table width="100%" cellpadding="0" cellspacing="0" class="section-header" style="margin: 0; border: 0; border-collapse: collapse; font-size: inherit; font-style: inherit; font-variant: inherit; font-weight: inherit; border-bottom: 1px solid #ddd; margin-top: 16px">
                                            <tbody>
                                                <tr>
                                                    <td style="font: 13px Arial, FreeSans, Helvetica, sans-serif; text-align: left; vertical-align: top"> <h3 style="font: 13px Arial, FreeSans, Helvetica, sans-serif; margin: 16px 0 0 0; font-size: 19px; margin: 0"><a href="http://bamboo.asterisk.org/browse/ASTTEAM-PIMPMYSIP-136/commit/" style="color: #326ca6; text-decoration: none">Code Changes</a></h3> </td>
                                                    <td class="utility" style="font: 13px Arial, FreeSans, Helvetica, sans-serif; text-align: left; vertical-align: top; text-align: right; vertical-align: middle; white-space: nowrap"> <a href="http://bamboo.asterisk.org/browse/ASTTEAM-PIMPMYSIP-136/commit/" style="color: #326ca6; text-decoration: none">View full change details</a> </td>
                                                </tr>
                                            </tbody>
                                        </table>
                                        <table width="100%" cellpadding="0" cellspacing="0" class="commits" style="margin: 0; border: 0; border-collapse: collapse; font-size: inherit; font-style: inherit; font-variant: inherit; font-weight: inherit; margin-top: 12px; margin-top: 8px">
                                            <tbody>
                                                <tr>
                                                    <td class="commit-avatar" style="font: 13px Arial, FreeSans, Helvetica, sans-serif; text-align: left; vertical-align: top; padding: 4px 0; width: 24px"> <img src="https://secure.gravatar.com/avatar/b24648b58839a1b2a1718b7089bcb57d.jpg?d=mm&amp;s=24&amp;r=g" width="24" height="24" style="border: 0; height: 24px; width: 24px" /> </td>
                                                    <td width="100%" style="font: 13px Arial, FreeSans, Helvetica, sans-serif; text-align: left; vertical-align: top; padding: 4px 0; padding-left: 4px; padding-left: 8px"> <a href="http://bamboo.asterisk.org/browse/author/root" style="color: #326ca6; text-decoration: none">root</a><br /> Merged revisions 382232,382236 via svnmerge from <br /> <a href="file:///srv/subversion/repos/asterisk/trunk" style="color: #326ca6; text-decoration: none">file:///srv/subversion/repos/asterisk/trunk</a><br /> <br /> ................<br /> &nbsp;&nbsp;r382232 | mjordan | 2013-02-28 10:56:20 -0600 (Thu, 28 Feb 2013) | 33 lines<br /> &nbsp;&nbsp;<br /> &nbsp;&nbsp;Let channels joining a MeetMe conference opt out of the denoiser<br /> &nbsp;&nbsp;<br /> &nbsp;&nbsp;For some channel drivers, specifically those that have a varying rate in the<br /> &nbsp;&nbsp;number of audio samples, the audio quality for a MeetMe conference can be<br /> &nbsp;&nbsp;exceedingly poor. This is due to a unilateral application of the DENOISE<br /> &nbsp;&nbsp;function in func_speex to channels joining the conference.<br /> &nbsp;&nbsp;<br /> &nbsp;&nbsp;The denoiser function in the speex library is initialized with the number of<br /> &nbsp;&nbsp;audio samples in each sample that will be provided to it. If the number of<br /> &nbsp;&nbsp;audio samples changes, the denoiser has to be thrown away and re-initialized.<br /> &nbsp;&nbsp;<br /> &nbsp;&nbsp;While this could be worked around by removing func_speex, that doesn't help<br /> &nbsp;&nbsp;if you actually use the denoiser with other channels on the system.<br /> &nbsp;&nbsp;<br /> &nbsp;&nbsp;This patches does the following:<br /> &nbsp;&nbsp;&nbsp;* Checks for the presence of func_speex as opposed to codec_speex when<br /> &nbsp;&nbsp;&nbsp;&nbsp;&nbsp;determining if the DENOISE function is present (which is where the function<br /> &nbsp;&nbsp;&nbsp;&nbsp;&nbsp;is actually implemented)<br /> &nbsp;&nbsp;&nbsp;* Adds an option to MeetMe 'n' that causes the denoiser to not be applied<br /> &nbsp;&nbsp;&nbsp;&nbsp;&nbsp;to a channel when it joins. This keeps the current behavior the default, but<br /> &nbsp;&nbsp;&nbsp;&nbsp;&nbsp;let's users disable the denoiser if it causes problems on their system.<br /> &nbsp;&nbsp;<br /> &nbsp;&nbsp;Review: <a href="https://reviewboard.asterisk.org/r/2358" style="color: #326ca6; text-decoration: none">https://reviewboard.asterisk.org/r/2358</a><br /> &nbsp;&nbsp;<br /> &nbsp;&nbsp;(closes issue <span class="jiraIssueLink" data-issue-key="AST-1062" data-bamboo-project-key="ASTTEAM">AST-1062</span>)<br /> &nbsp;&nbsp;Reported by: Thomas Arimont<br /> &nbsp;&nbsp;........<br /> &nbsp;&nbsp;<br /> &nbsp;&nbsp;Merged revisions 382227 from <a href="http://svn.asterisk.org/svn/asterisk/branches/1.8" style="color: #326ca6; text-decoration: none">http://svn.asterisk.org/svn/asterisk/branches/1.8</a><br /> &nbsp;&nbsp;........<br /> &nbsp;&nbsp;<br /> &nbsp;&nbsp;Merged revisions 382230 from <a href="http://svn.asterisk.org/svn/asterisk/branches/11" style="color: #326ca6; text-decoration: none">http://svn.asterisk.org/svn/asterisk/branches/11</a><br /> ................<br /> &nbsp;&nbsp;r382236 | mjordan | 2013-02-28 11:17:35 -0600 (Thu, 28 Feb 2013) | 25 lines<br /> &nbsp;&nbsp;<br /> &nbsp;&nbsp;Prevent deadlock in chan_iax2 when attempting to set caller ID<br /> &nbsp;&nbsp;<br /> &nbsp;&nbsp;A deadlock can occur in chan_iax2 when it attempts to set the caller ID, as it<br /> &nbsp;&nbsp;already holds the iax2 private lock and improperly fails to obtain the channel<br /> &nbsp;&nbsp;lock before calling ast_set_callerid. By not safely obtaining the channel lock,<br /> &nbsp;&nbsp;a locking inversion can take place, causing a deadlock.<br /> &nbsp;&nbsp;<br /> &nbsp;&nbsp;This patch solves this by calling the required deadlock avoidance functions<br /> &nbsp;&nbsp;that obtain the channel lock before setting the caller ID.<br /> &nbsp;&nbsp;<br /> &nbsp;&nbsp;Thanks to Pavel for fixing my syntax errors and testing this patch out.<br /> &nbsp;&nbsp;<br /> &nbsp;&nbsp;(closes issue <span class="jiraIssueLink" data-issue-key="ASTERISK-21128" data-bamboo-project-key="ASTTEAM">ASTERISK-21128</span>)<br /> &nbsp;&nbsp;Reported by: Pavel Troller<br /> &nbsp;&nbsp;Tested by: Pavel Troller<br /> &nbsp;&nbsp;patches:<br /> &nbsp;&nbsp;&nbsp;&nbsp;ASTERISK-21128-1.8.diff uploaded by mjordan (license 6283)<br /> &nbsp;&nbsp;&nbsp;&nbsp;ASTERISK-21128-modified-1.8.diff uploaded by Pavel Troller (license 6302)<br /> &nbsp;&nbsp;........<br /> &nbsp;&nbsp;<br /> &nbsp;&nbsp;Merged revisions 382233 from <a href="http://svn.asterisk.org/svn/asterisk/branches/1.8" style="color: #326ca6; text-decoration: none">http://svn.asterisk.org/svn/asterisk/branches/1.8</a><br /> &nbsp;&nbsp;........<br /> &nbsp;&nbsp;<br /> &nbsp;&nbsp;Merged revisions 382234 from <a href="http://svn.asterisk.org/svn/asterisk/branches/11" style="color: #326ca6; text-decoration: none">http://svn.asterisk.org/svn/asterisk/branches/11</a><br /> ................<br /> </td>
                                                    <td class="revision" style="font: 13px Arial, FreeSans, Helvetica, sans-serif; text-align: left; vertical-align: top; padding: 4px 0; padding-left: 4px; white-space: nowrap"> <span class="revision-id" style="background: #f0f0f0; border: 1px solid #ddd; -moz-border-radius: 3px; -webkit-border-radius: 3px; border-radius: 3px; display: inline-block; font-family: monospace; line-height: 1; max-width: 5em; overflow: hidden; padding: 2px 4px; text-overflow: ellipsis; vertical-align: top; white-space: nowrap; color: #505050">382237</span> </td>
                                                </tr>
                                            </tbody>
                                        </table>
                                        <table width="100%" cellpadding="0" cellspacing="0" class="section-header" style="margin: 0; border: 0; border-collapse: collapse; font-size: inherit; font-style: inherit; font-variant: inherit; font-weight: inherit; border-bottom: 1px solid #ddd; margin-top: 16px">
                                            <tbody>
                                                <tr>
                                                    <td style="font: 13px Arial, FreeSans, Helvetica, sans-serif; text-align: left; vertical-align: top"> <h3 style="font: 13px Arial, FreeSans, Helvetica, sans-serif; margin: 16px 0 0 0; font-size: 19px; margin: 0"><a href="http://bamboo.asterisk.org/browse/ASTTEAM-PIMPMYSIP-136/test" style="color: #326ca6; text-decoration: none">Tests</a></h3> </td>
                                                    <td class="utility" style="font: 13px Arial, FreeSans, Helvetica, sans-serif; text-align: left; vertical-align: top; text-align: right; vertical-align: middle; white-space: nowrap"> <a href="http://bamboo.asterisk.org/browse/ASTTEAM-PIMPMYSIP-136/test" style="color: #326ca6; text-decoration: none">View full test details</a> </td>
                                                </tr>
                                            </tbody>
                                        </table> <h4 style="font: 13px Arial, FreeSans, Helvetica, sans-serif; margin: 16px 0 0 0; font-size: 17px; margin-top: 12px">1 Fixed Tests</h4>
                                        <table width="100%" cellpadding="0" cellspacing="0" class="aui tests" style="margin: 0; border: 0; border-collapse: collapse; font-size: inherit; font-style: inherit; font-variant: inherit; font-weight: inherit; margin-top: 4px">
                                            <thead style="border-bottom: 1px solid #bbb">
                                                <tr>
                                                    <th colspan="2" style="font: 13px Arial, FreeSans, Helvetica, sans-serif; text-align: left; vertical-align: top; font-weight: bold; padding: 0.500em 0.400em 0.500em 0.600em; text-align: left; background: #f0f0f0; color: #000">Test</th>
                                                    <th style="font: 13px Arial, FreeSans, Helvetica, sans-serif; text-align: left; vertical-align: top; font-weight: bold; padding: 0.500em 0.400em 0.500em 0.600em; text-align: left; background: #f0f0f0; color: #000">Job</th>
                                                </tr>
                                            </thead>
                                            <tbody>
                                                <tr style="background: #fff; border-bottom: 1px solid #ddd; color: #111">
                                                    <td class="status-icon" style="font: 13px Arial, FreeSans, Helvetica, sans-serif; text-align: left; vertical-align: top; padding: 0.500em 0.400em 0.500em 0.600em; text-align: left; width: 16px; padding-bottom: 0; padding-right: 0"> <img src="http://bamboo.asterisk.org/images/iconsv3/plan_successful_16.png" style="border: 0; height: 16px; width: 16px" /> </td>
                                                    <td style="font: 13px Arial, FreeSans, Helvetica, sans-serif; text-align: left; vertical-align: top; padding: 0.500em 0.400em 0.500em 0.600em; text-align: left"> <span class="test-class">AsteriskUnitTests</span> <a href="http://bamboo.asterisk.org/browse/ASTTEAM-PIMPMYSIP-AST18CENTOS32-136/test/case/23101559" class="test-name" style="color: #326ca6; text-decoration: none">/main/threadpool/auto_increment</a> </td>
                                                    <td style="font: 13px Arial, FreeSans, Helvetica, sans-serif; text-align: left; vertical-align: top; padding: 0.500em 0.400em 0.500em 0.600em; text-align: left"> <a href="http://bamboo.asterisk.org/browse/ASTTEAM-PIMPMYSIP-AST18CENTOS32-136/test" style="color: #326ca6; text-decoration: none">Asterisk 1.8 CentOS 6 32-Bit</a> </td>
                                                </tr>
                                            </tbody>
                                        </table>
                                        <table width="100%" cellpadding="0" cellspacing="0" id="email-actions" class="email-metadata" style="margin: 0; border: 0; border-collapse: collapse; font-size: inherit; font-style: inherit; font-variant: inherit; font-weight: inherit; border-top: 1px solid #bbb; color: #505050; margin: 16px 0 0; padding: 0; color: #505050">
                                            <tbody>
                                                <tr>
                                                    <td class="left" style="font: 13px Arial, FreeSans, Helvetica, sans-serif; text-align: left; vertical-align: top; padding-top: 8px"> <span class="email-list-item"><a href="http://bamboo.asterisk.org/browse/ASTTEAM-PIMPMYSIP-136" style="color: #326ca6; text-decoration: none">View Online</a></span> <span class="email-list-divider" style="color: #505050; padding: 0 0.350em">|</span> <span class="email-list-item"><a href="http://bamboo.asterisk.org/browse/ASTTEAM-PIMPMYSIP-136?commentMode=true" style="color: #326ca6; text-decoration: none">Add Comments</a></span> </td>
                                                </tr>
                                            </tbody>
                                        </table> </td>
                                </tr>
                            </tbody>
                        </table>
                        <table id="email-footer" cellpadding="0" cellspacing="0" width="100%" style="margin: 0; border: 0; border-collapse: collapse; font-size: inherit; font-style: inherit; font-variant: inherit; font-weight: inherit">
                            <tbody>
                                <tr>
                                    <td style="font: 13px Arial, FreeSans, Helvetica, sans-serif; text-align: left; vertical-align: top; padding: 16px; text-align: center"> <p style="font: 13px Arial, FreeSans, Helvetica, sans-serif; margin: 16px 0 0 0; font-size: 11px; margin: 0"><small style="font-size: 11px">This message was sent by <a href="http://bamboo.asterisk.org" style="color: #326ca6; text-decoration: none">Atlassian Bamboo</a>.</small></p> <p style="font: 13px Arial, FreeSans, Helvetica, sans-serif; margin: 16px 0 0 0; font-size: 11px; margin: 0; margin-top: 4px"><small style="font-size: 11px">If you wish to stop receiving these emails edit your <a href="http://bamboo.asterisk.org/profile/userNotifications.action" style="color: #326ca6; text-decoration: none">user profile</a> or <a href="http://bamboo.asterisk.org/viewAdministrators.action" style="color: #326ca6; text-decoration: none">notify your administrator</a>.</small></p> </td>
                                </tr>
                            </tbody>
                        </table> </td>
                </tr>
            </tbody>
        </table>
    </body>
</html>