<html>
<head>
<meta charset="utf-8" />
<meta name="viewport" content="width=device-width" />
<style type="text/css">
a:hover, a:focus { text-decoration: underline !important; }
@media handheld, only screen and (max-device-width: 480px) {
div, a, p, td, th, li, dt, dd {
-webkit-text-size-adjust: auto;
}
small, small a {
-webkit-text-size-adjust: 90%;
}
small[class=email-metadata] {
-webkit-text-size-adjust: 93%;
font-size: 12px;
}
table[id=email-wrap] > tbody > tr > td {
padding: 2px !important;
}
table[id=email-wrap-inner] > tbody > tr > td {
padding: 8px !important;
}
table[id=email-footer] td {
padding: 8px 12px !important;
}
table[id=email-actions] td {
padding-top: 0 !important;
}
table[id=email-actions] td.right {
text-align: right !important;
}
table[id=email-actions] .email-list-item {
display: block;
margin: 1em 0 !important;
word-wrap: normal !important;
}
span[class=email-list-divider] {
display: none;
}
.commentsummary small[class=email-metadata] {
display: block;
}
td.comment-avatar {
padding: 8px 8px 0 8px !important;
}
.comment > td + td {
padding: 8px 8px 8px 0 !important;
}
}
</style>
</head>
<body style="font: 13px Arial, FreeSans, Helvetica, sans-serif; background: #f0f0f0; color: #505050">
<table id="email-wrap" align="center" cellpadding="0" cellspacing="0" width="100%" style="margin: 0; border: 0; border-collapse: collapse; font-size: inherit; font-style: inherit; font-variant: inherit; font-weight: inherit; background: #f0f0f0; color: #505050">
<tbody>
<tr>
<td style="font: 13px Arial, FreeSans, Helvetica, sans-serif; text-align: left; vertical-align: top; padding: 16px">
<div id="title-status" class="failed" style="font: 13px Arial, FreeSans, Helvetica, sans-serif; padding: 8px 0; background: #b33">
<table cellpadding="0" cellspacing="0" width="100%" style="margin: 0; border: 0; border-collapse: collapse; font-size: inherit; font-style: inherit; font-variant: inherit; font-weight: inherit; border-style: solid; border-width: 1px 0; table-layout: fixed; background: #a00; border-color: #a20000">
<tbody>
<tr>
<td id="title-status-icon" style="font: 13px Arial, FreeSans, Helvetica, sans-serif; text-align: left; vertical-align: top; padding: 8px 0 8px 8px; width: 24px"> <img src="http://bamboo.asterisk.org/images/iconsv3/plan_failed_16.png" alt="Failed" style="border: 0; height: 16px; width: 16px" /> </td>
<td id="title-status-text" style="font: 13px Arial, FreeSans, Helvetica, sans-serif; text-align: left; vertical-align: top; font-size: 16px; padding: 8px; text-shadow: 1px 1px 1px #500; color: #fff"> <span class="build" style="font-weight: bold"> <a href="http://bamboo.asterisk.org/browse/TESTING/" style="color: #326ca6; text-decoration: none; color: #fff">Asterisk Testing</a> › <a href="http://bamboo.asterisk.org/browse/TESTING-ASTERISK10BRANCH/" style="color: #326ca6; text-decoration: none; color: #fff">Asterisk 10 Branch</a> › <a href="http://bamboo.asterisk.org/browse/TESTING-ASTERISK10BRANCH-301/" style="color: #326ca6; text-decoration: none; color: #fff">#301</a> </span> <span class="status">failed</span> </td>
</tr>
</tbody>
</table>
</div>
<table id="email-wrap-inner" cellpadding="0" cellspacing="0" width="100%" style="margin: 0; border: 0; border-collapse: collapse; font-size: inherit; font-style: inherit; font-variant: inherit; font-weight: inherit; background: #fff; border: 1px solid #bbb; color: #000; border-top: 0">
<tbody>
<tr>
<td style="font: 13px Arial, FreeSans, Helvetica, sans-serif; text-align: left; vertical-align: top; padding: 16px"> <p class="trigger" style="font: 13px Arial, FreeSans, Helvetica, sans-serif; margin: 16px 0 0 0; margin-top: 4px">Code has been updated by <a href="http://bamboo.asterisk.org/browse/user/mjordan" style="color: #326ca6; text-decoration: none">Matthew Jordan</a>.</p> <p class="tests-summary" style="font: 13px Arial, FreeSans, Helvetica, sans-serif; margin: 16px 0 0 0; margin-top: 4px"> <strong>1/215</strong> tests failed. </p>
<table width="100%" cellpadding="0" cellspacing="0" class="section-header" style="margin: 0; border: 0; border-collapse: collapse; font-size: inherit; font-style: inherit; font-variant: inherit; font-weight: inherit; border-bottom: 1px solid #ddd; margin-top: 16px">
<tbody>
<tr>
<td style="font: 13px Arial, FreeSans, Helvetica, sans-serif; text-align: left; vertical-align: top"> <h3 style="font: 13px Arial, FreeSans, Helvetica, sans-serif; margin: 16px 0 0 0; font-size: 19px; margin: 0"><a href="http://bamboo.asterisk.org/browse/TESTING-ASTERISK10BRANCH-301/" style="color: #326ca6; text-decoration: none">Failing Jobs</a></h3> </td>
</tr>
</tbody>
</table>
<table width="100%" cellpadding="0" cellspacing="0" class="aui failing-jobs" style="margin: 0; border: 0; border-collapse: collapse; font-size: inherit; font-style: inherit; font-variant: inherit; font-weight: inherit; margin-top: 12px">
<thead style="border-bottom: 1px solid #bbb">
<tr>
<th colspan="2" style="font: 13px Arial, FreeSans, Helvetica, sans-serif; text-align: left; vertical-align: top; font-weight: bold; padding: 0.500em 0.400em 0.500em 0.600em; text-align: left; background: #f0f0f0; color: #000">Job</th>
<th style="font: 13px Arial, FreeSans, Helvetica, sans-serif; text-align: left; vertical-align: top; font-weight: bold; padding: 0.500em 0.400em 0.500em 0.600em; text-align: left; background: #f0f0f0; color: #000">Duration</th>
<th style="font: 13px Arial, FreeSans, Helvetica, sans-serif; text-align: left; vertical-align: top; font-weight: bold; padding: 0.500em 0.400em 0.500em 0.600em; text-align: left; background: #f0f0f0; color: #000">Tests</th>
<th style="font: 13px Arial, FreeSans, Helvetica, sans-serif; text-align: left; vertical-align: top; font-weight: bold; padding: 0.500em 0.400em 0.500em 0.600em; text-align: left; background: #f0f0f0; color: #000"></th>
</tr>
</thead>
<tbody>
<tr style="background: #fff; border-bottom: 1px solid #ddd; color: #111">
<td class="status-icon" style="font: 13px Arial, FreeSans, Helvetica, sans-serif; text-align: left; vertical-align: top; padding: 0.500em 0.400em 0.500em 0.600em; text-align: left; width: 16px; padding-bottom: 0; padding-right: 0"> <img src="http://bamboo.asterisk.org/images/iconsv3/plan_failed_16.png" alt="Failed" style="border: 0; height: 16px; width: 16px" /> </td>
<td class="failed" style="font: 13px Arial, FreeSans, Helvetica, sans-serif; text-align: left; vertical-align: top; padding: 0.500em 0.400em 0.500em 0.600em; text-align: left"> <a href="http://bamboo.asterisk.org/browse/TESTING-ASTERISK10BRANCH-AST18CENTOS64-301/" style="color: #326ca6; text-decoration: none">Asterisk CentOS 6 64-Bit</a> <span>(CentOS 6)</span> </td>
<td width="120" style="font: 13px Arial, FreeSans, Helvetica, sans-serif; text-align: left; vertical-align: top; padding: 0.500em 0.400em 0.500em 0.600em; text-align: left"> 71 minutes </td>
<td width="130" style="font: 13px Arial, FreeSans, Helvetica, sans-serif; text-align: left; vertical-align: top; padding: 0.500em 0.400em 0.500em 0.600em; text-align: left"> 1 of 215 failed </td>
<td class="actions" style="font: 13px Arial, FreeSans, Helvetica, sans-serif; text-align: left; vertical-align: top; padding: 0.500em 0.400em 0.500em 0.600em; text-align: left; text-align: right; white-space: nowrap"> <a href="http://bamboo.asterisk.org/browse/TESTING-ASTERISK10BRANCH-AST18CENTOS64-301/log" style="color: #326ca6; text-decoration: none">Logs</a> | <a href="http://bamboo.asterisk.org/browse/TESTING-ASTERISK10BRANCH-AST18CENTOS64-301/artifact" style="color: #326ca6; text-decoration: none">Artifacts</a> </td>
</tr>
</tbody>
</table>
<table width="100%" cellpadding="0" cellspacing="0" class="section-header" style="margin: 0; border: 0; border-collapse: collapse; font-size: inherit; font-style: inherit; font-variant: inherit; font-weight: inherit; border-bottom: 1px solid #ddd; margin-top: 16px">
<tbody>
<tr>
<td style="font: 13px Arial, FreeSans, Helvetica, sans-serif; text-align: left; vertical-align: top"> <h3 style="font: 13px Arial, FreeSans, Helvetica, sans-serif; margin: 16px 0 0 0; font-size: 19px; margin: 0"><a href="http://bamboo.asterisk.org/browse/TESTING-ASTERISK10BRANCH-301/commit/" style="color: #326ca6; text-decoration: none">Code Changes</a></h3> </td>
<td class="utility" style="font: 13px Arial, FreeSans, Helvetica, sans-serif; text-align: left; vertical-align: top; text-align: right; vertical-align: middle; white-space: nowrap"> <a href="http://bamboo.asterisk.org/browse/TESTING-ASTERISK10BRANCH-301/commit/" style="color: #326ca6; text-decoration: none">View full change details</a> </td>
</tr>
</tbody>
</table>
<table width="100%" cellpadding="0" cellspacing="0" class="commits" style="margin: 0; border: 0; border-collapse: collapse; font-size: inherit; font-style: inherit; font-variant: inherit; font-weight: inherit; margin-top: 12px; margin-top: 8px">
<tbody>
<tr>
<td class="commit-avatar" style="font: 13px Arial, FreeSans, Helvetica, sans-serif; text-align: left; vertical-align: top; padding: 4px 0; width: 24px"> <img src="https://secure.gravatar.com/avatar/519a8549643f67fe92fdb6b60f42d886.jpg?d=mm&s=24&r=g" width="24" height="24" style="border: 0; height: 24px; width: 24px" /> </td>
<td width="100%" style="font: 13px Arial, FreeSans, Helvetica, sans-serif; text-align: left; vertical-align: top; padding: 4px 0; padding-left: 4px; padding-left: 8px"> <a href="http://bamboo.asterisk.org/browse/user/mjordan" style="color: #326ca6; text-decoration: none">Matthew Jordan</a><br /> Handle extremely out of order RFC 2833 DTMF<br /> <br /> The current implementation of RFC 2833 DTMF handling in res_rtp_asterisk will,<br /> if a packet arrives out of order, drop the packet. This is to prevent<br /> duplicate ton generation in the Asterisk core. Since the RTP layer does not<br /> buffer data itself, this is the only option the RTP layer currently has for<br /> handling packets that arrive out of order.<br /> <br /> For the most part, this doesn't matter. For a particular digit, so long as a<br /> BEGIN packet arrives before the first END packet, the digit will be produced.<br /> If subsequent BEGIN packets arrive interleaved with the ENDs, they will be<br /> dropped; likewise, if the BEGIN or END packets themselves are out of order,<br /> those packets are dropped but sufficient information is conveyed to the<br /> Asterisk core to produce the appropriate digit.<br /> <br /> For certain sequences of DTMF packets - most notably when, for a particular<br /> digit, an END packet arrives before any BEGIN packet for that digit - this<br /> is a real problem. When an END arrives before any BEGINs, the END packet is<br /> dropped - but at the same time, it causes subsequent BEGIN packets for that<br /> digit to be ignored. When the next in order END packet arrives, it too is<br /> dropped - Asterisk believes that there was no initial BEGIN.<br /> <br /> The solution this patch provides is to trust the END packet to convey the<br /> information needed for the Asterisk core to produce the DTMF digit. If we<br /> receive an END packet, and it:<br /> * Has a timestamp greater then the last timestamp received from an END<br /> packet<br /> * Does not have the same sequence number as the last received sequence<br /> number (and is thus not an END packet retransmission)<br /> Then we send the END frame up to the Asterisk core. It contains enough<br /> DTMF information for Asterisk to produce the digit.<br /> <br /> On the other hand, if we receive a BEGIN or continuation packet that occurs<br /> with a timestamp equal to or less then the last END timestamp, then we've<br /> received something out of order - but we already have received enough<br /> information to produce the digit. These packets are dropped.<br /> <br /> Much thanks goes to Olle Johansson (oej) for providing the idea for this<br /> solution.<br /> <br /> Review: <a href="https://reviewboard.asterisk.org/r/2033/" style="color: #326ca6; text-decoration: none">https://reviewboard.asterisk.org/r/2033/</a><br /> <br /> (issue <span class="jiraIssueLink" data-issue-key="ASTERISK-18404" data-bamboo-project-key="TESTING">ASTERISK-18404</span>)<br /> Reporter: Stephane Chazelas<br /> Tested by: Matt Jordan<br /> ........<br /> <br /> Merged revisions 370252 from <a href="http://svn.asterisk.org/svn/asterisk/branches/1.8" style="color: #326ca6; text-decoration: none">http://svn.asterisk.org/svn/asterisk/branches/1.8</a><br /> </td>
<td class="revision" style="font: 13px Arial, FreeSans, Helvetica, sans-serif; text-align: left; vertical-align: top; padding: 4px 0; padding-left: 4px; white-space: nowrap"> <span class="revision-id" style="background: #f0f0f0; border: 1px solid #ddd; -moz-border-radius: 3px; -webkit-border-radius: 3px; border-radius: 3px; display: inline-block; font-family: monospace; line-height: 1; max-width: 5em; overflow: hidden; padding: 2px 4px; text-overflow: ellipsis; vertical-align: top; white-space: nowrap; color: #505050">370271</span> </td>
</tr>
</tbody>
</table>
<table width="100%" cellpadding="0" cellspacing="0" class="section-header" style="margin: 0; border: 0; border-collapse: collapse; font-size: inherit; font-style: inherit; font-variant: inherit; font-weight: inherit; border-bottom: 1px solid #ddd; margin-top: 16px">
<tbody>
<tr>
<td style="font: 13px Arial, FreeSans, Helvetica, sans-serif; text-align: left; vertical-align: top"> <h3 style="font: 13px Arial, FreeSans, Helvetica, sans-serif; margin: 16px 0 0 0; font-size: 19px; margin: 0"><a href="http://bamboo.asterisk.org/browse/TESTING-ASTERISK10BRANCH-301/test" style="color: #326ca6; text-decoration: none">Tests</a></h3> </td>
<td class="utility" style="font: 13px Arial, FreeSans, Helvetica, sans-serif; text-align: left; vertical-align: top; text-align: right; vertical-align: middle; white-space: nowrap"> <a href="http://bamboo.asterisk.org/browse/TESTING-ASTERISK10BRANCH-301/test" style="color: #326ca6; text-decoration: none">View full test details</a> </td>
</tr>
</tbody>
</table> <h4 style="font: 13px Arial, FreeSans, Helvetica, sans-serif; margin: 16px 0 0 0; font-size: 17px; margin-top: 12px">1 New Test Failures</h4>
<table width="100%" cellpadding="0" cellspacing="0" class="aui tests" style="margin: 0; border: 0; border-collapse: collapse; font-size: inherit; font-style: inherit; font-variant: inherit; font-weight: inherit; margin-top: 4px">
<thead style="border-bottom: 1px solid #bbb">
<tr>
<th colspan="2" style="font: 13px Arial, FreeSans, Helvetica, sans-serif; text-align: left; vertical-align: top; font-weight: bold; padding: 0.500em 0.400em 0.500em 0.600em; text-align: left; background: #f0f0f0; color: #000">Test</th>
<th style="font: 13px Arial, FreeSans, Helvetica, sans-serif; text-align: left; vertical-align: top; font-weight: bold; padding: 0.500em 0.400em 0.500em 0.600em; text-align: left; background: #f0f0f0; color: #000">Job</th>
</tr>
</thead>
<tbody>
<tr style="background: #fff; border-bottom: 1px solid #ddd; color: #111">
<td class="status-icon" style="font: 13px Arial, FreeSans, Helvetica, sans-serif; text-align: left; vertical-align: top; padding: 0.500em 0.400em 0.500em 0.600em; text-align: left; width: 16px; padding-bottom: 0; padding-right: 0"> <img src="http://bamboo.asterisk.org/images/iconsv3/plan_failed_16.png" style="border: 0; height: 16px; width: 16px" /> </td>
<td style="font: 13px Arial, FreeSans, Helvetica, sans-serif; text-align: left; vertical-align: top; padding: 0.500em 0.400em 0.500em 0.600em; text-align: left"> <span class="test-class">AsteriskTestSuite</span> <a href="http://bamboo.asterisk.org/browse/TESTING-ASTERISK10BRANCH-AST18CENTOS64-301/test/case/16778118" class="test-name" style="color: #326ca6; text-decoration: none">tests/chanspy/chanspy_barge</a> </td>
<td style="font: 13px Arial, FreeSans, Helvetica, sans-serif; text-align: left; vertical-align: top; padding: 0.500em 0.400em 0.500em 0.600em; text-align: left"> <a href="http://bamboo.asterisk.org/browse/TESTING-ASTERISK10BRANCH-AST18CENTOS64-301/test" style="color: #326ca6; text-decoration: none">Asterisk CentOS 6 64-Bit</a> </td>
</tr>
</tbody>
</table>
<table width="100%" cellpadding="0" cellspacing="0" id="email-actions" class="email-metadata" style="margin: 0; border: 0; border-collapse: collapse; font-size: inherit; font-style: inherit; font-variant: inherit; font-weight: inherit; border-top: 1px solid #bbb; color: #505050; margin: 16px 0 0; padding: 0; color: #505050">
<tbody>
<tr>
<td class="left" style="font: 13px Arial, FreeSans, Helvetica, sans-serif; text-align: left; vertical-align: top; padding-top: 8px"> <span class="email-list-item"><a href="http://bamboo.asterisk.org/browse/TESTING-ASTERISK10BRANCH-301" style="color: #326ca6; text-decoration: none">View Online</a></span> <span class="email-list-divider" style="color: #505050; padding: 0 0.350em">|</span> <span class="email-list-item"><a href="http://bamboo.asterisk.org/browse/TESTING-ASTERISK10BRANCH-301?commentMode=true" style="color: #326ca6; text-decoration: none">Add Comments</a></span> </td>
</tr>
</tbody>
</table> </td>
</tr>
</tbody>
</table>
<table id="email-footer" cellpadding="0" cellspacing="0" width="100%" style="margin: 0; border: 0; border-collapse: collapse; font-size: inherit; font-style: inherit; font-variant: inherit; font-weight: inherit">
<tbody>
<tr>
<td style="font: 13px Arial, FreeSans, Helvetica, sans-serif; text-align: left; vertical-align: top; padding: 16px; text-align: center"> <p style="font: 13px Arial, FreeSans, Helvetica, sans-serif; margin: 16px 0 0 0; font-size: 11px; margin: 0"><small style="font-size: 11px">This message was sent by <a href="http://bamboo.asterisk.org" style="color: #326ca6; text-decoration: none">Atlassian Bamboo</a>.</small></p> <p style="font: 13px Arial, FreeSans, Helvetica, sans-serif; margin: 16px 0 0 0; font-size: 11px; margin: 0; margin-top: 4px"><small style="font-size: 11px">If you wish to stop receiving these emails edit your <a href="http://bamboo.asterisk.org/profile/userNotifications.action" style="color: #326ca6; text-decoration: none">user profile</a> or <a href="http://bamboo.asterisk.org/viewAdministrators.action" style="color: #326ca6; text-decoration: none">notify your administrator</a>.</small></p> </td>
</tr>
</tbody>
</table> </td>
</tr>
</tbody>
</table>
</body>
</html>