<div>
<style type="text/css">
.successful a, .successful a:visited, .successful a:link, .successful a:hover,.successful  a:active {color:#393}
.failed a, .failed a:visited, .failed a:link, .failed a:hover,.failed  a:active {color:#d62829}
.notexecuted a, .notexecuted a:visited, .notexecuted a:link, .notexecuted a:hover,.notexecuted  a:active {color:#ffcc66}
td a, td a:link, td a:visited, td a:hover, td a:active {background:transparent;font-family: Arial, sans-serif;text-decoration:underline;}
td a:link {color:#369;}
td a:visited {color:#444;}
td a:hover, td a:active {color:#036;}
td a:hover {text-decoration:none;}
</style>
<font size="2" color="black" face="Arial, Helvetica, sans-serif" style="font-family: Arial, sans-serif;font-size: 13px;color:#000">
<table align="center" border="0" cellpadding="5" cellspacing="0" width="98%">

<tr>
        <td style="vertical-align:top">
        <table width="100%" border="0" cellpadding="0" cellspacing="0" style="background-color:#ffe6e7;border-top:1px solid #eec0c0;border-bottom:1px solid #eec0c0;color:#d62829;">
            <tr>
                <td width="20" style="vertical-align:top;padding:5px 0 5px 10px">
                    <img src="http://bamboo.asterisk.org/images/iconsv3/plan_failed_16.png" width="15" height="15">
                </td>
                <td width="100%" style="font-family: Arial, sans-serif; font-size: 13px; color:#d62829;padding:5px 10px">
      <a href="http://bamboo.asterisk.org/browse/AST18/" style="font-family: Arial, sans-serif; font-size: 15px; font-weight:bold; color:#d62829">Asterisk - 1.8</a> &gt;
      <a href="http://bamboo.asterisk.org/browse/AST18-LUCID/" style="font-family: Arial, sans-serif; font-size: 15px; font-weight:bold; color:#d62829">Ubuntu Lucid (10.04)</a> &gt;
      <a href="http://bamboo.asterisk.org/browse/AST18-LUCID-705/" style="font-family: Arial, sans-serif; font-size: 15px; font-weight:bold; color:#d62829">#705</a>
                    <span class="failed" style="font-family: Arial, sans-serif; font-size: 14px;"> has failed.</span>
                    <span class="failed" style="font-family: Arial, sans-serif; font-size: 13px;">
                    <br/>Code has been updated by <a href="http://bamboo.asterisk.org/browse/author/rmudgett">rmudgett</a>.
                            <br/><strong>2/118</strong> tests failed.
                    </span>
                </td>
            </tr>
        </table>
        <br>
  <table width="100%" border="0" cellpadding="0" cellspacing="0" style="background-color:#ecf1f7;border-top:1px solid #bbd0e5;border-bottom:1px solid #bbd0e5;color:#036;">
        <tr>
            <td width="60%" style="font-family: Arial, sans-serif;text-align:left;font-size:16px;font-weight:bold;color:#036;padding:5px 10px">
                <a href="http://bamboo.asterisk.org/browse/AST18-LUCID-705/" style="text-decoration: none; font-family: Arial, sans-serif;text-align:left;font-size:16px;font-weight:bold;color:#036" >Failing Jobs</a>
            </td>
            <td width="40%" style="font-family: Arial, sans-serif;text-align:right;font-size:13px;color:#036;padding:5px 10px">
            </td>
        </tr>
   </table>
         <table  width="100%" border="0" cellpadding="0" cellspacing="0">
    <tr>
        <td width="20" style="vertical-align:top;padding:11px 0 5px 10px; border-bottom:1px solid #EEEEEE; ">
                <img src="http://bamboo.asterisk.org/images/iconsv3/plan_failed_16.png" width="15" height="15">
        </td>
        <td style="font-family: Arial, sans-serif; font-size: 13px; vertical-align:top;padding:10px 5px 10px 5px; border-bottom:1px solid #EEEEEE;">
                 <a href="http://bamboo.asterisk.org/browse/AST18-LUCID-AMD64-705/"  style="color:red;">amd64</a>
             <span style="color:#444444; font-size:11px; font-style:italic;">(Default Stage)</span>
        </td>
        <td width="120" style="font-family: Arial, sans-serif; font-size: 13px; vertical-align:top;padding:10px 5px 10px 5px; border-bottom:1px solid #EEEEEE;color:#444444; font-size:11px">
                <b>Duration:</b> 26 minutes
        </td>
        <td width="130" style="font-family: Arial, sans-serif; font-size: 13px; vertical-align:top;padding:10px 5px 10px 5px; border-bottom:1px solid #EEEEEE;color:#444444; font-size:11px">
                <b>Tests:</b> 2 of 118 failed
        </td>
        <td width="80" style="font-family: Arial, sans-serif; font-size: 13px; vertical-align:top;padding:10px 5px 10px 5px; border-bottom:1px solid #EEEEEE;font-size:11px">
                <a href="http://bamboo.asterisk.org/browse/AST18-LUCID-AMD64-705/log">Logs</a> | <a href="http://bamboo.asterisk.org/browse/AST18-LUCID-AMD64-705/artifact">Artifacts</a>
        </td>
    </tr>
        </table>
        <br/>
  <table width="100%" border="0" cellpadding="0" cellspacing="0" style="background-color:#ecf1f7;border-top:1px solid #bbd0e5;border-bottom:1px solid #bbd0e5;color:#036;">
        <tr>
            <td width="60%" style="font-family: Arial, sans-serif;text-align:left;font-size:16px;font-weight:bold;color:#036;padding:5px 10px">
                <a href="http://bamboo.asterisk.org/browse/AST18-LUCID-705/commit/" style="text-decoration: none; font-family: Arial, sans-serif;text-align:left;font-size:16px;font-weight:bold;color:#036" >Code Changes</a>
            </td>
            <td width="40%" style="font-family: Arial, sans-serif;text-align:right;font-size:13px;color:#036;padding:5px 10px">
                <a href="http://bamboo.asterisk.org/browse/AST18-LUCID-705/commit/" style="font-family: Arial, sans-serif; font-size: 13px; color:#036">See full change details</a><img src="http://bamboo.asterisk.org/images/icons/more.gif" width="15" height="15" style="vertical-align:middle;padding:2px">
            </td>
        </tr>
   </table>
    <table width="100%" border="0" cellpadding="0" cellspacing="0">
                <tr><td width="20" style="vertical-align:top;padding:10px 0 0px 10px">
                        <img src="http://bamboo.asterisk.org/images/icons/businessman.gif" width="15" height="15">
                    </td>
                    <td width="100%" style="font-family: Arial, sans-serif; font-size: 13px; color:#000;vertical-align:top;padding:10px 10px 0px 10px">
                        <a href="http://bamboo.asterisk.org/browse/author/rmudgett" style="font-family: Arial, sans-serif; font-size: 13px; font-weight:bold; color:#000">
                           rmudgett</a><br>
                        Call pickup race leaves orphaned channels or crashes.<br/>
<br/>
Multiple users attempting to pickup a call that has been forked to<br/>
multiple extensions either crashes or fails a masquerade with a &quot;bad<br/>
things may happen&quot; message.<br/>
<br/>
This is the scenario that is causing all the grief:<br/>
1) Pickup target is selected<br/>
2) target is marked as being picked up in ast_do_pickup()<br/>
3) target is unlocked by ast_do_pickup()<br/>
4) app dial or queue gets a chance to hang up losing calls and calls<br/>
ast_hangup() on target<br/>
5) SINCE A MASQUERADE HAS NOT BEEN SETUP YET BY ast_do_pickup() with<br/>
ast_channel_masquerade(), ast_hangup() completes successfully and the<br/>
channel is no longer in the channels container.<br/>
6) ast_do_pickup() then calls ast_channel_masquerade() to schedule the<br/>
masquerade on the dead channel.<br/>
7) ast_do_pickup() then calls ast_do_masquerade() on the dead channel<br/>
8) bad things happen while doing the masquerade and in the process<br/>
ast_do_masquerade() puts the dead channel back into the channels container<br/>
9) The &quot;orphaned&quot; channel is visible in the channels list if a crash does<br/>
not happen.<br/>
<br/>
This patch does the following:<br/>
<br/>
* Made ast_hangup() set AST_FLAG_ZOMBIE on a successfully hung-up channel<br/>
and not release the channel lock until that has happened.<br/>
<br/>
* Made __ast_channel_masquerade() not setup a masquerade if either channel<br/>
has AST_FLAG_ZOMBIE set.<br/>
<br/>
* Fix chan_agent misuse of AST_FLAG_ZOMBIE since it would no longer work.<br/>
<br/>
(closes issue ASTERISK-18222)<br/>
Reported by: Alec Davis<br/>
Tested by: rmudgett, Alec Davis, irroot, Karsten Wemheuer<br/>
<br/>
(closes issue ASTERISK-18273)<br/>
Reported by: Karsten Wemheuer<br/>
Tested by: rmudgett, Alec Davis, irroot, Karsten Wemheuer<br/>
<br/>
Review: <a href="https://reviewboard.asterisk.org/r/1400/">https://reviewboard.asterisk.org/r/1400/</a><br/>

                    </td>
                    <td width="60" style="font-family: Arial, sans-serif; font-size: 13px; ;color:#036;vertical-align:top;padding:10px 10px 0px 10px">
                         (334009)
                    </td></tr>
    </table><br>
            <table width="100%" border="0" cellpadding="0" cellspacing="0" style="background-color:#ecf1f7;border-top:1px solid #bbd0e5;border-bottom:1px solid #bbd0e5;color:#036;">
                <tr>
                    <td width="60%" style="font-family: Arial, sans-serif;text-align:left;font-size:16px;font-weight:bold;color:#036;vertical-align:top;padding:5px 10px">
                        <a href="http://bamboo.asterisk.org/browse/AST18-LUCID-705/test" style="text-decoration: none; font-family: Arial, sans-serif;text-align:left;font-size:16px;font-weight:bold;color:#036" >Tests</a>
                    </td>
                    <td width="40%" style="font-family: Arial, sans-serif;text-align:right;font-size:13px;color:#036;padding:5px 10px">
                        <a href="http://bamboo.asterisk.org/browse/AST18-LUCID-705/test" style="font-family: Arial, sans-serif; font-size: 13px;color:#036">See full test details</a><img src="http://bamboo.asterisk.org/images/icons/more.gif" width="15" height="15" style="vertical-align:middle;padding:2px">
                    </td>
                </tr>
            </table>
            <table width="100%" border="0" cellpadding="0" cellspacing="0">
        <tr>
            <td colspan="2" width="100%" style="font-family: Arial, sans-serif; font-size: 13px; font-weight:bold; color:#000;vertical-align:top;padding:10px 0 0 10px">
                New Test Failures (2)
            </td>
        </tr>
<tr>
<td width="20" style="vertical-align:top;padding:5px 0 5px 10px">
<img src="http://bamboo.asterisk.org/images/iconsv3/plan_failed_16.png" width="15" height="15">
</td>
<td width="100%" style="font-family: Arial, sans-serif; font-size: 13px; color:#000;vertical-align:top;padding:5px 10px">
AsteriskTestSuite :
<a href="http://bamboo.asterisk.org/browse/AST18-LUCID-AMD64-705/test/case/5375660" style="font-family: Arial, sans-serif; font-size: 13px;color:#000">S/fastagi/say-digits</a>
<a href="http://bamboo.asterisk.org/browse/AST18-LUCID-AMD64-705/test" style="font-family: Arial, sans-serif; font-size: 13px;color:#999">(amd64)</a>
</td>
</tr><tr>
<td width="20" style="vertical-align:top;padding:5px 0 5px 10px">
<img src="http://bamboo.asterisk.org/images/iconsv3/plan_failed_16.png" width="15" height="15">
</td>
<td width="100%" style="font-family: Arial, sans-serif; font-size: 13px; color:#000;vertical-align:top;padding:5px 10px">
AsteriskTestSuite :
<a href="http://bamboo.asterisk.org/browse/AST18-LUCID-AMD64-705/test/case/13599156" style="font-family: Arial, sans-serif; font-size: 13px;color:#000">S/apps/directory context operator exit</a>
<a href="http://bamboo.asterisk.org/browse/AST18-LUCID-AMD64-705/test" style="font-family: Arial, sans-serif; font-size: 13px;color:#999">(amd64)</a>
</td>
</tr>            </table><br>

    </td>
    <td width="150" style="vertical-align:top">
    <table width="150" border="0" cellpadding="0" cellspacing="0" style="background-color:#ecf1f7;border-top:1px solid #bbd0e5;border-bottom:1px solid #bbd0e5;color:#036;">
        <tr>
            <td style="font-family: Arial, sans-serif;text-align:left;font-size:16px;font-weight:bold;color:#036;vertical-align:top;padding:5px 10px">
                Actions
            </td>
        </tr>
    </table>
    <table width="150" border="0" cellpadding="0" cellspacing="0" style="background-color:#f5f9fc;border-bottom:1px solid #bbd0e5;">
        <tr>
            <td style="font-family: Ariel, sans-serif; font-size: 13px; color:#036;vertical-align:top;padding:5px 10px;line-height:1.7">
    <a href="http://bamboo.asterisk.org/browse/AST18-LUCID-705" style="font-family: Arial, sans-serif; font-size: 13px; color:#036">View Online</a>
    <br>
    <a href="http://bamboo.asterisk.org/browse/AST18-LUCID-705?commentMode=true" style="font-family: Arial, sans-serif; font-size: 13px; color:#036">Add Comments</a>
    <br>
            </td>
        </tr>
    </table>
    </td>
</tr>
<tr>
    <td>
<table width="100%" border="0" cellpadding="0" cellspacing="0">
    <tr><td colspan="2" align="center" style="font-family: Arial, sans-serif;text-align:center;font-size:11px;font-weight:bold;color:#999;vertical-align:top;padding:20px">
        Email generated by <a href="http://bamboo.asterisk.org" style="font-family: Arial, sans-serif; font-size: 11px; color:#999">Atlassian Bamboo</a> - if you wish to stop receiving these emails edit your  <a href="http://bamboo.asterisk.org/profile/userNotifications.action" style="font-family: Arial, sans-serif; font-size: 11px; color:#999">user profile</a> or <a href="http://bamboo.asterisk.org/viewAdministrators.action" style="font-family: Arial, sans-serif; font-size: 11px; color:#999">notify your administrator</a>
    </td>
    </tr>
</table>
    </td>
</tr>
</table>
</font>
</div>