<div>
<style type="text/css">
.successful a, .successful a:visited, .successful a:link, .successful a:hover,.successful  a:active {color:#393}
.failed a, .failed a:visited, .failed a:link, .failed a:hover,.failed  a:active {color:#d62829}
.notexecuted a, .notexecuted a:visited, .notexecuted a:link, .notexecuted a:hover,.notexecuted  a:active {color:#ffcc66}
td a, td a:link, td a:visited, td a:hover, td a:active {background:transparent;font-family: Arial, sans-serif;text-decoration:underline;}
td a:link {color:#369;}
td a:visited {color:#444;}
td a:hover, td a:active {color:#036;}
td a:hover {text-decoration:none;}
</style>
<font size="2" color="black" face="Arial, Helvetica, sans-serif" style="font-family: Arial, sans-serif;font-size: 13px;color:#000">
<table align="center" border="0" cellpadding="5" cellspacing="0" width="98%">

<tr>
        <td style="vertical-align:top">
        <table width="100%" border="0" cellpadding="0" cellspacing="0" style="background-color:#ffe6e7;border-top:1px solid #eec0c0;border-bottom:1px solid #eec0c0;color:#d62829;">
            <tr>
                <td width="20" style="vertical-align:top;padding:5px 0 5px 10px">
                    <img src="http://bamboo.asterisk.org/images/jt/icn_plan_failed.gif" width="15" height="15">
                </td>
                <td width="100%" style="font-family: Arial, sans-serif; font-size: 13px; color:#d62829;padding:5px 10px">
      <a href="http://bamboo.asterisk.org/browse/AST/" style="font-family: Arial, sans-serif; font-size: 15px; font-weight:bold; color:#d62829">Asterisk</a> &gt;
      <a href="http://bamboo.asterisk.org/browse/AST-SOLARIS1032/" style="font-family: Arial, sans-serif; font-size: 15px; font-weight:bold; color:#d62829">1.8 - Solaris 10 - i686</a> &gt;
      <a href="http://bamboo.asterisk.org/browse/AST-SOLARIS1032-83/" style="font-family: Arial, sans-serif; font-size: 15px; font-weight:bold; color:#d62829">#83</a>
                    <span class="failed" style="font-family: Arial, sans-serif; font-size: 14px;"> has failed.</span>
                    <span class="failed" style="font-family: Arial, sans-serif; font-size: 13px;">
                    <br/>Code has been updated by <a href="http://bamboo.asterisk.org/browse/author/twilson">twilson</a>, <a href="http://bamboo.asterisk.org/browse/user/russell">Russell Bryant</a>, <a href="http://bamboo.asterisk.org/browse/author/sruffell">sruffell</a>, <a href="http://bamboo.asterisk.org/browse/author/jpeeler">jpeeler</a>, <a href="http://bamboo.asterisk.org/browse/author/rmudgett">rmudgett</a>, <a href="http://bamboo.asterisk.org/browse/author/bbryant">bbryant</a>, <a href="http://bamboo.asterisk.org/browse/user/pabelanger">Paul Belanger</a>, <a href="http://bamboo.asterisk.org/browse/author/dvossel">dvossel</a>, <a href="http://bamboo.asterisk.org/browse/user/mnicholson">Matthew Nicholson</a>, <a href="http://bamboo.asterisk.org/browse/user/tilghman">Tilghman Lesher</a>.
                            <br/>No failed tests found, a possible compilation error.
                    </span>
                </td>
            </tr>
        </table>
        <br>
  <table width="100%" border="0" cellpadding="0" cellspacing="0" style="background-color:#ecf1f7;border-top:1px solid #bbd0e5;border-bottom:1px solid #bbd0e5;color:#036;">
        <tr>
            <td width="60%" style="font-family: Arial, sans-serif;text-align:left;font-size:16px;font-weight:bold;color:#036;padding:5px 10px">
                <a href="http://bamboo.asterisk.org/browse/AST-SOLARIS1032-83/" style="text-decoration: none; font-family: Arial, sans-serif;text-align:left;font-size:16px;font-weight:bold;color:#036" >Failing Jobs</a>
            </td>
            <td width="40%" style="font-family: Arial, sans-serif;text-align:right;font-size:13px;color:#036;padding:5px 10px">
            </td>
        </tr>
   </table>
         <table  width="100%" border="0" cellpadding="0" cellspacing="0">
    <tr>
        <td width="20" style="vertical-align:top;padding:11px 0 5px 10px; border-bottom:1px solid #EEEEEE; ">
                <img src="http://bamboo.asterisk.org/images/jt/icn_plan_failed.gif" width="15" height="15">
        </td>
        <td style="font-family: Arial, sans-serif; font-size: 13px; vertical-align:top;padding:10px 5px 10px 5px; border-bottom:1px solid #EEEEEE;">
                 <a href="http://bamboo.asterisk.org/browse/AST-SOLARIS1032-JOB1-83/"  style="color:red;">Default Job</a>
             <span style="color:#444444; font-size:11px; font-style:italic;">(Default Stage)</span>
        </td>
        <td width="120" style="font-family: Arial, sans-serif; font-size: 13px; vertical-align:top;padding:10px 5px 10px 5px; border-bottom:1px solid #EEEEEE;color:#444444; font-size:11px">
                <b>Duration:</b> 8 minutes
        </td>
        <td width="130" style="font-family: Arial, sans-serif; font-size: 13px; vertical-align:top;padding:10px 5px 10px 5px; border-bottom:1px solid #EEEEEE;color:#444444; font-size:11px">
                <b>Tests:</b> No tests found
        </td>
        <td width="80" style="font-family: Arial, sans-serif; font-size: 13px; vertical-align:top;padding:10px 5px 10px 5px; border-bottom:1px solid #EEEEEE;font-size:11px">
                <a href="http://bamboo.asterisk.org/browse/AST-SOLARIS1032-JOB1-83/log">Logs</a> | <a href="http://bamboo.asterisk.org/browse/AST-SOLARIS1032-JOB1-83/artifact">Artifacts</a>
        </td>
    </tr>
        </table>
        <br/>
  <table width="100%" border="0" cellpadding="0" cellspacing="0" style="background-color:#ecf1f7;border-top:1px solid #bbd0e5;border-bottom:1px solid #bbd0e5;color:#036;">
        <tr>
            <td width="60%" style="font-family: Arial, sans-serif;text-align:left;font-size:16px;font-weight:bold;color:#036;padding:5px 10px">
                <a href="http://bamboo.asterisk.org/browse/AST-SOLARIS1032-83/commit/" style="text-decoration: none; font-family: Arial, sans-serif;text-align:left;font-size:16px;font-weight:bold;color:#036" >Code Changes</a>
            </td>
            <td width="40%" style="font-family: Arial, sans-serif;text-align:right;font-size:13px;color:#036;padding:5px 10px">
                <a href="http://bamboo.asterisk.org/browse/AST-SOLARIS1032-83/commit/" style="font-family: Arial, sans-serif; font-size: 13px; color:#036">View all 45 code changes</a><img src="http://bamboo.asterisk.org/images/icons/more.gif" width="15" height="15" style="vertical-align:middle;padding:2px">
            </td>
        </tr>
   </table>
    <table width="100%" border="0" cellpadding="0" cellspacing="0">
                <tr><td width="20" style="vertical-align:top;padding:10px 0 0px 10px">
                        <img src="http://bamboo.asterisk.org/images/icons/businessman.gif" width="15" height="15">
                    </td>
                    <td width="100%" style="font-family: Arial, sans-serif; font-size: 13px; color:#000;vertical-align:top;padding:10px 10px 0px 10px">
                        <a href="http://bamboo.asterisk.org/browse/author/jpeeler" style="font-family: Arial, sans-serif; font-size: 13px; font-weight:bold; color:#000">
                           jpeeler</a><br>
                        Merged revisions 294639 via svnmerge from <br/>
<a href="https://origsvn.digium.com/svn/asterisk/branches/1.6.2">https://origsvn.digium.com/svn/asterisk/branches/1.6.2</a><br/>
<br/>
................<br/>
&nbsp;&nbsp;r294639 | jpeeler | 2010-11-11 13:31:00 -0600 (Thu, 11 Nov 2010) | 53 lines<br/>
&nbsp;&nbsp;<br/>
&nbsp;&nbsp;Merged revisions 294384 via svnmerge from <br/>
&nbsp;&nbsp;<a href="https://origsvn.digium.com/svn/asterisk/branches/1.4">https://origsvn.digium.com/svn/asterisk/branches/1.4</a><br/>
&nbsp;&nbsp;<br/>
&nbsp;&nbsp;........<br/>
&nbsp;&nbsp;&nbsp;&nbsp;r294384 | jpeeler | 2010-11-09 11:37:59 -0600 (Tue, 09 Nov 2010) | 47 lines<br/>
&nbsp;&nbsp;&nbsp;&nbsp;<br/>
&nbsp;&nbsp;&nbsp;&nbsp;Fix a deadlock in device state change processing.<br/>
&nbsp;&nbsp;&nbsp;&nbsp;<br/>
&nbsp;&nbsp;&nbsp;&nbsp;Copied from some notes from the original author (Russell):<br/>
&nbsp;&nbsp;&nbsp;&nbsp;<br/>
&nbsp;&nbsp;&nbsp;&nbsp;Deadlock scenario:<br/>
&nbsp;&nbsp;&nbsp;&nbsp;Thread 1: device state change thread<br/>
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;Holds - rdlock on contexts<br/>
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;Holds - hints lock<br/>
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;Waiting on channels container lock<br/>
&nbsp;&nbsp;&nbsp;&nbsp;<br/>
&nbsp;&nbsp;&nbsp;&nbsp;Thread 2: SIP monitor thread<br/>
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;Holds the &quot;iflock&quot;<br/>
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;Holds a sip_pvt lock<br/>
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;Holds channel container lock<br/>
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;Waiting for a channel lock<br/>
&nbsp;&nbsp;&nbsp;&nbsp;<br/>
&nbsp;&nbsp;&nbsp;&nbsp;Thread 3: A channel thread (chan_local in this case)<br/>
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;Holds 2 channel locks acquired within app_dial<br/>
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;Holds a 3rd channel lock it got inside of chan_local<br/>
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;Holds a local_pvt lock<br/>
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;Waiting on a rdlock of the contexts lock<br/>
&nbsp;&nbsp;&nbsp;&nbsp;<br/>
&nbsp;&nbsp;&nbsp;&nbsp;A bunch of other threads waiting on a wrlock of the contexts lock<br/>
&nbsp;&nbsp;&nbsp;&nbsp;<br/>
&nbsp;&nbsp;&nbsp;&nbsp;<br/>
&nbsp;&nbsp;&nbsp;&nbsp;To address this deadlock, some locking order rules must be put in place and<br/>
&nbsp;&nbsp;&nbsp;&nbsp;enforced. Existing relevant rules:<br/>
&nbsp;&nbsp;&nbsp;&nbsp;<br/>
&nbsp;&nbsp;&nbsp;&nbsp;1) channel lock before a pvt lock<br/>
&nbsp;&nbsp;&nbsp;&nbsp;2) contexts lock before hints lock<br/>
&nbsp;&nbsp;&nbsp;&nbsp;3) channels container before a channel<br/>
&nbsp;&nbsp;&nbsp;&nbsp;<br/>
&nbsp;&nbsp;&nbsp;&nbsp;What's missing is some enforcement of the order when you involve more than any<br/>
&nbsp;&nbsp;&nbsp;&nbsp;two. To fix this problem, I put in some code that ensures that (at least in the<br/>
&nbsp;&nbsp;&nbsp;&nbsp;code paths involved in this bug) the locks in (3) come before the locks in (2).<br/>
&nbsp;&nbsp;&nbsp;&nbsp;To change the operation of thread 1 to comply, I converted the storage of hints<br/>
&nbsp;&nbsp;&nbsp;&nbsp;to an astobj2 container. This allows processing of hints without holding the<br/>
&nbsp;&nbsp;&nbsp;&nbsp;hints container lock. So, in the code path that led to thread 1's state, it no<br/>
&nbsp;&nbsp;&nbsp;&nbsp;longer holds either the contexts or hints lock while it attempts to lock the<br/>
&nbsp;&nbsp;&nbsp;&nbsp;channels container.<br/>
&nbsp;&nbsp;&nbsp;&nbsp;<br/>
&nbsp;&nbsp;&nbsp;&nbsp;(closes issue #18165)<br/>
&nbsp;&nbsp;&nbsp;&nbsp;Reported by: antonio<br/>
&nbsp;&nbsp;&nbsp;&nbsp;<br/>
&nbsp;&nbsp;&nbsp;&nbsp;ABE-2583<br/>
&nbsp;&nbsp;........<br/>
................<br/>

                    </td>
                    <td width="60" style="font-family: Arial, sans-serif; font-size: 13px; ;color:#036;vertical-align:top;padding:10px 10px 0px 10px">
                         (294640)
                    </td></tr>
                <tr><td width="20" style="vertical-align:top;padding:10px 0 0px 10px">
                        <img src="http://bamboo.asterisk.org/images/icons/businessman.gif" width="15" height="15">
                    </td>
                    <td width="100%" style="font-family: Arial, sans-serif; font-size: 13px; color:#000;vertical-align:top;padding:10px 10px 0px 10px">
                        <a href="http://bamboo.asterisk.org/browse/user/tilghman" style="font-family: Arial, sans-serif; font-size: 13px; font-weight:bold; color:#000">
                           Tilghman Lesher</a><br>
                        Properly queue files with inotify(7).<br/>
<br/>
(closes issue #18089)<br/>
&nbsp;Reported by: abelbeck<br/>
&nbsp;Patches: <br/>
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;20101021__issue18089.diff.txt uploaded by tilghman (license 14)<br/>
&nbsp;Tested by: tilghman<br/>

                    </td>
                    <td width="60" style="font-family: Arial, sans-serif; font-size: 13px; ;color:#036;vertical-align:top;padding:10px 10px 0px 10px">
                         (294569)
                    </td></tr>
                <tr><td width="20" style="vertical-align:top;padding:10px 0 0px 10px">
                        <img src="http://bamboo.asterisk.org/images/icons/businessman.gif" width="15" height="15">
                    </td>
                    <td width="100%" style="font-family: Arial, sans-serif; font-size: 13px; color:#000;vertical-align:top;padding:10px 10px 0px 10px">
                        <a href="http://bamboo.asterisk.org/browse/author/jpeeler" style="font-family: Arial, sans-serif; font-size: 13px; font-weight:bold; color:#000">
                           jpeeler</a><br>
                        Modify sip_setoption to not complain about unknown options.<br/>
<br/>
This now behaves just like the other setoption callbacks. For the curious the<br/>
offending option for the reporter was AST_OPTION_CHANNEL_WRITE which was getting<br/>
passed due to a fix for chan_local in 286189.<br/>
<br/>
(closes issue #17985)<br/>
Reported by: globalnetinc<br/>

                    </td>
                    <td width="60" style="font-family: Arial, sans-serif; font-size: 13px; ;color:#036;vertical-align:top;padding:10px 10px 0px 10px">
                         (293305)
                    </td></tr>
            <tr><td colspan="3">
                <br/><a href="http://bamboo.asterisk.org/browse/AST-SOLARIS1032-83/commit" style="font-family: Arial, sans-serif; font-size: 13px; color:#036">42 more changes...</a>
            </td></tr>
    </table><br>

    </td>
    <td width="150" style="vertical-align:top">
    <table width="150" border="0" cellpadding="0" cellspacing="0" style="background-color:#ecf1f7;border-top:1px solid #bbd0e5;border-bottom:1px solid #bbd0e5;color:#036;">
        <tr>
            <td style="font-family: Arial, sans-serif;text-align:left;font-size:16px;font-weight:bold;color:#036;vertical-align:top;padding:5px 10px">
                Actions
            </td>
        </tr>
    </table>
    <table width="150" border="0" cellpadding="0" cellspacing="0" style="background-color:#f5f9fc;border-bottom:1px solid #bbd0e5;">
        <tr>
            <td style="font-family: Ariel, sans-serif; font-size: 13px; color:#036;vertical-align:top;padding:5px 10px;line-height:1.7">
    <a href="http://bamboo.asterisk.org/browse/AST-SOLARIS1032-83" style="font-family: Arial, sans-serif; font-size: 13px; color:#036">View Online</a>
    <br>
    <a href="http://bamboo.asterisk.org/browse/AST-SOLARIS1032-83?commentMode=true" style="font-family: Arial, sans-serif; font-size: 13px; color:#036">Add Comments</a>
    <br>
            </td>
        </tr>
    </table>
    </td>
</tr>
<tr>
    <td>
<table width="100%" border="0" cellpadding="0" cellspacing="0">
    <tr><td colspan="2" align="center" style="font-family: Arial, sans-serif;text-align:center;font-size:11px;font-weight:bold;color:#999;vertical-align:top;padding:20px">
        Email generated by <a href="http://bamboo.asterisk.org" style="font-family: Arial, sans-serif; font-size: 11px; color:#999">Atlassian Bamboo</a> - if you wish to stop receiving these emails edit your  <a href="http://bamboo.asterisk.org/profile/userNotifications.action" style="font-family: Arial, sans-serif; font-size: 11px; color:#999">user profile</a> or <a href="http://bamboo.asterisk.org/viewAdministrators.action" style="font-family: Arial, sans-serif; font-size: 11px; color:#999">notify your administrator</a>
    </td>
    </tr>
</table>
    </td>
</tr>
</table>
</font>
</div>