[test-results] [Bamboo] Asterisk Testing > Asterisk Trunk > #1129 has FAILED (1 tests failed). Change made by Matthew Jordan.

[Bamboo]

-----------------------------------------------------------------------
Asterisk Testing > Asterisk Trunk > #1129 failed.
-----------------------------------------------------------------------
Code has been updated by Matthew Jordan.
1/2 jobs failed, with 1 failing test.

http://bamboo.asterisk.org/browse/TESTING-ASTERISKTRUNK-1129/


--------------
Failing Jobs
--------------
  - Asterisk CentOS 6 32-Bit (CentOS 6): 1 of 466 tests failed.



--------------
Code Changes
--------------
Matthew Jordan (383879):

>Resolve deadlock between SIP registration and channel based functions
>
>In r373424, several reentrancy problems in chan_sip were addressed. As a
>result, the SIP channel driver is now properly locking the channel driver
>private information in certain operations that it wasn't previously. This
>exposed two latent problems either in register_verify or by functions called
>by register_verify. This includes:
> * Holding the private lock while calling sip_send_mwi_to_peer. This can create
>   a new sip_pvt via sip_alloc, which will obtain the channel container lock.
>   This is a locking inversion, as any channel related lock must be obtained
>   prior to obtaining the SIP channel technology private lock.
>
>   Note that this issue was already fixed in Asterisk 11.
>
> * Holding the private lock while calling sip_poke_peer. In the same vein as
>   sip_send_mwi_to_peer, sip_poke_peer can create a new SIP private, causing
>   the same locking inversion.
>
>Note that this locking inversion typically occured when CLI commands were run
>while a SIP REGISTER request was being processed, as many CLI commands (such
>as 'sip show channels', 'core show channels', etc.) have to obtain the channel
>container lock.
>
>(issue ASTERISK-21068)
>Reported by: Nicolas Bouliane
>
>(issue ASTERISK-20550)
>Reported by: David Brillert
>
>(issue ASTERISK-21314)
>Reported by: Badalian Vyacheslav
>
>(issue ASTERISK-21296)
>Reported by: Gabriel Birke
>........
>
>Merged revisions 383863 from http://svn.asterisk.org/svn/asterisk/branches/1.8
>........
>
>Merged revisions 383878 from http://svn.asterisk.org/svn/asterisk/branches/11
>



--------------
Tests
--------------
New Test Failures (1)
   - AsteriskTestSuite: S/apps/control playback/control restart
Fixed Tests (2)
   - AsteriskTestSuite: S/apps/control playback/control reverse
   - AsteriskTestSuite: S/apps/control playback/control forward

--
This message is automatically generated by Atlassian Bamboo
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/test-results/attachments/20130326/47f7a20d/attachment-0001.htm>