[test-results] [Bamboo] Asterisk Testing > Asterisk Trunk > #1081 has FAILED. Change made by Matthew Jordan.

Bamboo bamboo at asterisk.org
Fri Mar 8 03:13:14 CST 2013


-----------------------------------------------------------------------
Asterisk Testing > Asterisk Trunk > #1081 failed.
-----------------------------------------------------------------------
Code has been updated by Matthew Jordan.
2/2 jobs failed, no tests found.

http://bamboo.asterisk.org/browse/TESTING-ASTERISKTRUNK-1081/


--------------
Failing Jobs
--------------
  - Asterisk CentOS 6 32-Bit (CentOS 6): No tests found.
  - Asterisk CentOS 6 64-Bit (CentOS 6): No tests found.



--------------
Code Changes
--------------
Matthew Jordan (382670):

>Don't reset the RTP address on a glare re-INVITE
>
>Originally, way back in r201583, we added the alternate RTP address so
>that the RTP engine would expect to receive audio from a new source
>when a glare re-INVITE occurred. In r382589, we remove the alternate
>RTP source, as the 'secret' probation mode allows for switching to a new
>RTP source when a previous source stops sending RTP. At the time, it
>seemed appropriate to set the RTP source based on the information in the
>glared re-INVITE.
>
>Unfortunately, that doesn't work so well - in a glared re-INVITE that occurs
>with no SDP - such as in a connected line update that glances - we'll set
>the RTP source to an invalid address. In subsequent re-INVITE requests from
>this Asterisk instance, we'll then send an invalid media address, which will
>result in the remote side sending a 488. Whoops.
>
>There isn't any need to reset the RTP source - if we're using strictrtp, we'll
>simply synchronize to a new source when we stop getting packets from the old
>one. If we aren't using strictrtp, then again there shouldn't be a problem.
>
>Note that the Asterisk Test Suite's connectedline test caught this error.



--
This message is automatically generated by Atlassian Bamboo
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/test-results/attachments/20130308/273fa820/attachment-0001.htm>


More information about the Test-results mailing list