[test-results] [Bamboo] Asterisk - Team Branches > roibos-cng-support-1.8 > #74 has FAILED. Change made by root.

Bamboo bamboo at asterisk.org
Wed Jan 30 13:44:32 CST 2013


-----------------------------------------------------------------------
Asterisk - Team Branches > roibos-cng-support-1.8 > #74 failed.
-----------------------------------------------------------------------
Code has been updated by root.
No failed tests found, a possible compilation error.

http://bamboo.asterisk.org/browse/ASTTEAM-ROIBUSCNGSUPPORT18-74/


--------------
Failing Jobs
--------------
  - Asterisk 1.8 CentOS 6 32-Bit (CentOS 6): No tests found.



--------------
Code Changes
--------------
root (380475):

>Merged revisions 380451,380458 via svnmerge from 
>file:///srv/subversion/repos/asterisk/branches/1.8
>
>........
>  r380451 | mjordan | 2013-01-30 08:12:19 -0600 (Wed, 30 Jan 2013) | 12 lines
>  
>  Fix memory leak in res_calendar_icalendar
>  
>  The ICalendar module had a systemic memory leak on each fetch of data from
>  the ICalendar source. The previous fetched data was not being properly
>  disposed. This patch makes it so that before each fetch of data, we dispose
>  of the previously fetched data.
>  
>  (closes issue ASTERISK-21012)
>  Reported by: Joel Vandal
>  Tested by: Joel Vandal
>........
>  r380458 | mjordan | 2013-01-30 08:19:14 -0600 (Wed, 30 Jan 2013) | 31 lines
>  
>  Perform case insensitive comparisons for T.38 attributes
>  
>  RFC5347 section 2.5.2 states the following:
>  ...
>  The attribute "T38MaxBitRate" was once incorrectly registered with
>  IANA as "T38maxBitRate" (lower-case "m"). In accordance with T.38
>  examples and common implementation practice, the form "T38MaxBitRate"
>  SHOULD be generated by implementations conforming to this package.
>  In general, it is RECOMMENDED that implementations of this package
>  accept lowercase, uppercase, and mixed upper/lowercase encodings of
>  all the T.38 attributes.
>  ...
>  
>  Asterisk currently does not perform case insensitive matching on the T.38
>  attributes. This causes the T38MaxBitRate attribute to be negotiated at
>  2400 baud instead of 14400 (or whatever value you actually wanted).
>  
>  This patch makes it so that when we compare T.38 attributes, we do so in a case
>  insensitive fashion.
>  
>  Note that while the issue reporter did not directly write the patch, they
>  contributed to it (and would have provided one themselves if the license had
>  gone through a tad faster), and hence get attribution for it.
>  
>  (closes issue ASTERISK-20897)
>  Reported by: Eric Hill
>  Tested by: Eric Hill
>  patches:
>    -- uploaded by Eric Hill
>........
>



--
This message is automatically generated by Atlassian Bamboo
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/test-results/attachments/20130130/55fece80/attachment.htm>


More information about the Test-results mailing list