[test-results] [Bamboo] Asterisk - Team Branches > roibos-cng-support-1.8 > #70 has FAILED. Change made by root.

[Bamboo]

-----------------------------------------------------------------------
Asterisk - Team Branches > roibos-cng-support-1.8 > #70 failed.
-----------------------------------------------------------------------
Code has been updated by root.
No failed tests found, a possible compilation error.

http://bamboo.asterisk.org/browse/ASTTEAM-ROIBUSCNGSUPPORT18-70/


--------------
Failing Jobs
--------------
  - Asterisk 1.8 CentOS 6 32-Bit (CentOS 6): No tests found.



--------------
Code Changes
--------------
root (380238):

>Merged revisions 380210 via svnmerge from 
>file:///srv/subversion/repos/asterisk/branches/1.8
>
>........
>  r380210 | russell | 2013-01-27 19:52:39 -0600 (Sun, 27 Jan 2013) | 22 lines
>  
>  Change cleanup ordering in filestream destructor.
>  
>  This patch came about due to a problem observed where wav files had an
>  empty header.  The header is supposed to be updated in wav_close().  It
>  turns out that this was broken when the cache_record_files option from
>  asterisk.conf was enabled.  The cleanup code was moving the file to its
>  final destination *before* running the close() method of the file
>  destructor, so the header didn't get updated.
>  
>  Another problem here is that the move was being done before actually
>  closing the FILE *.
>  
>  Finally, the last bug fixed here is that I noticed that wav_close()
>  checks for stream->filename to be non-NULL.  In the previous cleanup
>  order, it's checking a pointer to freed memory.  This doesn't actually
>  cause anything to break, but it's treading on dangerous waters.  Now the
>  free() of stream->filename is happening after the format module's
>  close() method gets called, so it's safer.
>  
>  Review: https://reviewboard.asterisk.org/r/2286/
>........
>



--
This message is automatically generated by Atlassian Bamboo
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/test-results/attachments/20130128/46b92bd6/attachment.htm>