[test-results] [Bamboo] Asterisk - Team Branches > roibos-cng-support-1.8 > #50 has FAILED. Change made by root.

[Bamboo]

-----------------------------------------------------------------------
Asterisk - Team Branches > roibos-cng-support-1.8 > #50 failed.
-----------------------------------------------------------------------
Code has been updated by root.
No failed tests found, a possible compilation error.

http://bamboo.asterisk.org/browse/ASTTEAM-ROIBUSCNGSUPPORT18-50/


--------------
Failing Jobs
--------------
  - Asterisk 1.8 CentOS 6 32-Bit (CentOS 6): No tests found.



--------------
Code Changes
--------------
root (378963):

>Merged revisions 378933 via svnmerge from 
>file:///srv/subversion/repos/asterisk/branches/1.8
>
>................
>  r378933 | dlee | 2013-01-12 00:26:34 -0600 (Sat, 12 Jan 2013) | 36 lines
>  
>  Fix XML encoding of 'identity display' in NOTIFY messages.
>  
>  XML encoding in chan_sip is accomplished by naively building the XML
>  directly from strings. While this usually works, it fails to take into
>  account escaping the reserved characters in XML.
>  
>  This patch adds an 'ast_xml_escape' function, which works similarly to
>  'ast_uri_encode'. This is used to properly escape the local_display
>  attribute in XML formatted NOTIFY messages.
>  
>  Several things to note:
>   * The Right Thing(TM) to do would probably be to replace the
>     ast_build_string stuff with building an ast_xml_doc. That's a much
>     bigger change, and out of scope for the original ticket, so I
>     refrained myself.
>   * It is with great sadness that I wrote my own ast_xml_escape
>     function. There's one in libxml2, but it's knee-deep in
>     libxml2-ness, and not easily used to one-off escape a
>     string.
>   * I only escaped the string we know is causing problems
>     (local_display). At least some of the other strings are
>     URI-encoded, which should be XML safe. Rather than figuring out
>     what's safe and escaping what's not, it would be much cleaner to
>     simply build an ast_xml_doc for the messages and let the XML
>     library do the XML escaping. Like I said, that's out of scope.
>  
>  (closes issue ABE-2902)
>  Reported by: Guenther Kelleter
>  Tested by: Guenther Kelleter
>  Review: http://reviewboard.digium.internal/r/365/
>  
>  ........
>  
>  Merged revision 378919 from https://origsvn.digium.com/svn/asterisk/be/branches/C.3-bier
>................
>



--
This message is automatically generated by Atlassian Bamboo
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/test-results/attachments/20130112/ab8bdc13/attachment.htm>