[test-results] [Bamboo] Asterisk Testing > Asterisk Trunk > #693 was SUCCESSFUL (with 289 tests). Change made by rmudgett.

Bamboo bamboo at asterisk.org
Tue Sep 25 23:01:52 CDT 2012


-----------------------------------------------------------------------
Asterisk Testing > Asterisk Trunk > #693 was successful.
-----------------------------------------------------------------------
Code has been updated by rmudgett.
289 tests in total.

http://bamboo.asterisk.org/browse/TESTING-ASTERISKTRUNK-693/


--------------
Code Changes
--------------
rmudgett (373471):

>Fix potential reentrancy problems in chan_sip.
>
>Asterisk v1.8 and later was not as vulnerable to this issue.
>
>* Made find_call() lock each private as it processes the found dialogs.
>(Primary cause of ABE-2876)
>
>* Made the other functions that traverse the dialogs container lock each
>private as it examines them.
>
>* Fix race condition in sip_call() if the thread that sent the INVITE is
>held up long enough for a response to be processed.  The p->initid for the
>INVITE retransmission could be added after it was canceled by the response
>processing.
>
>* Made __sip_destroy() clean up resource pointers after freeing.  This is
>primarily defensive in case someone has a stale private pointer.
>
>* Removed redundant memset() in reqprep().  The call to init_req() already
>does the memset() and is the first reference to req in reqprep().
>
>* Removed useless set of req.method in transmit_invite().  The calls to
>initreqprep() and reqprep() have to do this because they memset() the req.
>
>JIRA ABE-2876
>
>..........
>
>Merged -r373423 from https://origsvn.digium.com/svn/asterisk/be/branches/C.3-bier
>........
>
>Merged revisions 373424 from http://svn.asterisk.org/svn/asterisk/branches/1.8
>........
>
>Merged revisions 373466 from http://svn.asterisk.org/svn/asterisk/branches/10
>........
>
>Merged revisions 373469 from http://svn.asterisk.org/svn/asterisk/branches/11
>



--------------
Tests
--------------
Fixed Tests (1)
   - AsteriskTestSuite: S/channels/ s i p/sip attended transfer tcp

--
This message is automatically generated by Atlassian Bamboo
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/test-results/attachments/20120925/04d7557b/attachment.htm>


More information about the Test-results mailing list