[test-results] [Bamboo] Asterisk Testing > Asterisk 1.8 Branch > #390 has FAILED (1 tests failed). Change made by Matthew Jordan and rmudgett.

Bamboo bamboo at asterisk.org
Wed Sep 19 17:15:11 CDT 2012


-----------------------------------------------------------------------
Asterisk Testing > Asterisk 1.8 Branch > #390 failed.
-----------------------------------------------------------------------
Code has been updated by Matthew Jordan, rmudgett.
1/2 jobs failed, with 1 failing test.

http://bamboo.asterisk.org/browse/TESTING-ASTERISK18BRANCH-390/


--------------
Failing Jobs
--------------
  - Asterisk 1.8 CentOS 6 32-Bit (CentOS 6): 1 of 174 tests failed.



--------------
Code Changes
--------------
rmudgett (373090):

>Made companding law for SS7 calls only determined by SS7 signaling type.
>
>For SS7, the companding law for a call was chosen inconsistently depending
>upon ss7type (ITU vs ANSI) and the DAHDI companding default (T1 vs E1).
>For incoming calls, the companding law was determined by ss7type.  For
>outgoing calls, the companding law was determined by the DAHDI default.
>With the wrong combination you would get A-law/u-law conflicts.  An
>A-law/u-law conflict sounds like bad static on the line.
>
>SS7 ITU  signaling with E1 line: ok
>SS7 ITU  signaling with T1 line: noise
>SS7 ANSI signaling with E1 line: noise
>SS7 ANSI signaling with T1 line: ok
>
>* Fix the companding law used to be determined by the SS7 signaling type
>only.
>

Matthew Jordan (373061):

>Resolve memory leaks in TLS initialization and TLS client connections
>
>This patch resolves two sources of memory leaks when using TLS in Asterisk:
>1) It removes improper initialization (and multiple re-initializations) of
>   portions of the SSL library.  Asterisk calls SSL_library_init and
>   SSL_load_error_strings during SSL initialization; collectively this
>   obviates the need for calling any of the following during initialization
>   or client connection handling:
>   * ERR_load_crypto_strings (handled by SSL_load_error_strings)
>   * OpenSSL_add_all_algorithms (synonym for SSL_library_init)
>   * SSLeay_add_ssl_algorithms (synonym for SSL_library_init)
>2) Failure to completely clean up all memory allocated by Asterisk and by
>   the SSL library for TLS clients.  This included not freeing the SSL_CTX
>   object in the SIP channel driver, as well as not clearing the error
>   stack when the TLS client exited.
>
>Note that these memory leaks were found by Thomas Arimont, and this patch
>was essentially written by him with some minor tweaks.
>
>(closes issue AST-889)
>Reported by: Thomas Arimont
>Tested by: Thomas Arimont
>patches:
>  (bugAST-889.patch) by Thomas Arimont (license 5525)
>
>Review: https://reviewboard.asterisk.org/r/2105
>
>



--------------
Tests
--------------
New Test Failures (1)
   - AsteriskTestSuite: S/fastagi/say-date

--
This message is automatically generated by Atlassian Bamboo
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/test-results/attachments/20120919/524b615d/attachment-0001.htm>


More information about the Test-results mailing list