[test-results] [Bamboo] Asterisk Testing > Asterisk 1.8 Branch > #424 has FAILED (1 tests failed, no failures were new). Change made by dlee.

Bamboo bamboo at asterisk.org
Sat Oct 6 07:42:21 CDT 2012


-----------------------------------------------------------------------
Asterisk Testing > Asterisk 1.8 Branch > #424 failed.
-----------------------------------------------------------------------
Code has been updated by dlee.
1/189 tests failed, no failures were new.

http://bamboo.asterisk.org/browse/TESTING-ASTERISK18BRANCH-424/


--------------
Failing Jobs
--------------
  - Asterisk 1.8 CentOS 6 64-Bit (CentOS 6): 1 of 189 tests failed.



--------------
Code Changes
--------------
dlee (374570):

>Improve AMI long line error handling
>
>In AMI's parser, when it receives a long line (> 1024 characters), it discards
>that line, but continues to process the message normally.
>
>Typically, this is not a problem because a) who has lines that long and b)
>usually a discarded line results in an invalid message. But if that line is
>specifying an optional field, then the message will be processed, you get a
>'Response: Success', but things don't work the way you expected them to.
>
>This patch changes the behavior when a line-too-long parse error occurs.
>
>* Changes the log message to avoid way-too-long (and truncated anyways) log
>  messages
>* Adds a 'parsing' status flag to Response: Success
>* Sets parsing = MESSAGE_LINE_TOO_LONG if, well, a line is too long
>* Responds with an appropriate error if parsing != MESSAGE_OKAY
>
>(closes issue AST-961)
>Reported by: John Bigelow
>Review: https://reviewboard.asterisk.org/r/2142/
>



--------------
Tests
--------------
Existing Test Failures (1)
   - AsteriskTestSuite: S/channels/ s i p/sip outbound address

--
This message is automatically generated by Atlassian Bamboo
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/test-results/attachments/20121006/1c66052a/attachment.htm>


More information about the Test-results mailing list