[test-results] [Bamboo] Asterisk Testing > Asterisk 1.8 Branch > #62 has FAILED (1 tests failed). Change made by rmudgett.

Bamboo bamboo at asterisk.org
Tue Mar 20 13:14:29 CDT 2012


-----------------------------------------------------------------------
Asterisk Testing > Asterisk 1.8 Branch > #62 failed.
-----------------------------------------------------------------------
Code has been updated by rmudgett.
1/167 tests failed.

http://bamboo.asterisk.org/browse/TESTING-ASTERISK18BRANCH-62/


--------------
Failing Jobs
--------------
  - Asterisk 1.8 CentOS 6 64-Bit (CentOS 6): 1 of 167 tests failed.


--------------
Code Changes
--------------
rmudgett (359979):

>Allow AMI action callback to be reentrant.
>
>Fix AMI module reload deadlock regression from ASTERISK-18479 when it
>tried to fix the race between calling an AMI action callback and
>unregistering that action.  Refixes ASTERISK-13784 broken by
>ASTERISK-17785 change.
>
>Locking the ao2 object guaranteed that there were no active callbacks that
>mattered when ast_manager_unregister() was called.  Unfortunately, this
>causes the deadlock situation.  The patch stops locking the ao2 object to
>allow multiple threads to invoke the callback re-entrantly.  There is no
>way to guarantee a module unload will not crash because of an active
>callback.  The code attempts to minimize the chance with the registered
>flag and the maximum 5 second delay before ast_manager_unregister()
>returns.
>
>The trunk version of the patch changes the API to fix the race condition
>correctly to prevent the module code from unloading from memory while an
>action callback is active.
>
>* Don't hold the lock while calling the AMI action callback.
>
>(closes issue ASTERISK-19487)
>Reported by: Philippe Lindheimer
>
>Review: https://reviewboard.asterisk.org/r/1818/
>Review: https://reviewboard.asterisk.org/r/1820/
>


--------------
Tests
--------------
New Test Failures (1)
   - AsteriskTestSuite: S/redirecting/subroutine

--
This message is automatically generated by Atlassian Bamboo
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/test-results/attachments/20120320/17b3b7bd/attachment.htm>


More information about the Test-results mailing list