[test-results] [Bamboo] Asterisk Testing > Asterisk Trunk > #539 has FAILED (4 tests failed, 3 failures were new). Change made by Kinsey Moore.

[Bamboo]

-----------------------------------------------------------------------
Asterisk Testing > Asterisk Trunk > #539 failed.
-----------------------------------------------------------------------
Code has been updated by Kinsey Moore.
4/281 tests failed, 3 failures were new.

http://bamboo.asterisk.org/browse/TESTING-ASTERISKTRUNK-539/


--------------
Failing Jobs
--------------
  - Asterisk CentOS 6 64-Bit (CentOS 6): 4 of 281 tests failed.



--------------
Code Changes
--------------
Kinsey Moore (370636):

>Clean up chan_sip
>
>This clean up was broken out from
>https://reviewboard.asterisk.org/r/1976/ and addresses the following:
> - struct sip_refer converted to use the stringfields API.
> - sip_{refer|notify}_allocate -> sip_{notify|refer}_alloc to match
>   other *alloc functions.
> - Replace get_msg_text, get_msg_text2 and get_pidf_body -> No, not
>   get_pidf_msg_text_body3 but get_content, to match add_content.
> - get_body doesn't get the request body, renamed to get_content_line.
> - get_body_by_line doesn't get the body line, and is just a simple if
>   test. Moved code inline and removed function.
> - Remove camelCase in struct sip_peer peer state variables,
>   onHold -> onhold, inUse -> inuse, inRinging -> ringing.
> - Remove camelCase in struct sip_request rlPart1 -> rlpart1,
>   rlPart2 -> rlpart2.
> - Rename instances of pvt->randdata to pvt->nonce because that is what
>   it is, no need to update struct sip_pvt because _it already has a
>   nonce field_.
> - Removed struct sip_pvt randdata stringfield.
> - Remove useless (and inconsistent) 'header' suffix on variables in
>   handle_request_subscribe.
> - Use ast_strdupa on Event header in handle_request_subscribe to avoid
>   overly complicated strncmp calls to find the event package.
> - Move get_destination check in handle_request_subscribe to avoid
>   duplicate checking for packages that don't need it.
> - Move extension state callback management in handle_request_subscribe
>   to avoid duplicate checking for packages that don't need it.
> - Remove duplicate append_date prototype.
> - Rename append_date -> add_date to match other add_xxx functions.
> - Added add_expires helper function, removed code that manually added
>   expires header.
> - Remove _header suffix on add_diversion_header (no other header adding
>   functions have this).
> - Don't pass req->debug to request handle_request_XXXXX handlers if req
>   is also being passed.
> - Don't pass req->ignore to check_auth as req is already being passed.
> - Don't create a subscription in handle_request_subscribe if
>   p->expiry == 0.
> - Don't walk of the back of referred_by_name when splitting string in
>   get_refer_info
> - Remove duplicate check for no dialog in handle_incoming when
>   sipmethod == SIP_REFER, handle_request_refer checks for that.
>
>Review: https://reviewboard.asterisk.org/r/1993/
>Patch-by: gareth
>



--------------
Tests
--------------
New Test Failures (3)
   - AsteriskTestSuite: S/channels/ s i p/sip custom presence/multiple state change
   - AsteriskTestSuite: S/channels/ s i p/sip custom presence/nominal state change
   - AsteriskTestSuite: S/channels/ s i p/sip custom presence/resubscribe
Existing Test Failures (1)
   - AsteriskTestSuite: S/channels/ s i p/generic ccss

--
This message is automatically generated by Atlassian Bamboo
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/test-results/attachments/20120731/4d587ea1/attachment-0001.htm>