[test-results] [Bamboo] Asterisk - 1.8 > Compile > #26 has FAILED. Change made by Matthew Jordan.

[Bamboo]

-----------------------------------------------------------------------
Asterisk - 1.8 > Compile > #26 failed.
-----------------------------------------------------------------------
Code has been updated by Matthew Jordan.
4/6 jobs failed, no tests found.

http://bamboo.asterisk.org/browse/AST18-COMPILE-26/


--------------
Failing Jobs
--------------
  - pbuilder-maverick-amd64 (Compile packages): No tests found.
  - pbuilder-natty-amd64 (Compile packages): No tests found.
  - pbuilder-oneiric-amd64 (Compile packages): No tests found.
  - pbuilder-precise-amd64 (Compile packages): No tests found.


--------------
Code Changes
--------------
Matthew Jordan (356214):

>Fix potential buffer overrun and memory leak when executing "sip show peers"
>
>The "sip show peers" command uses a fix sized array to sort the current peers
>in the peers ao2_container.  The size of the array is based on the current
>number of peers in the container.  However, once the size of the array is
>determined, the number of peers in the container can change, as the peers
>container is not locked.  This could cause a buffer overrun when populating
>the array, if peers were added to the container after the array was created.
>Additionally, a memory leak of the allocated array would occur if a user
>caused the _show_peers method to return CLI_SHOWUSAGE.
>
>We now create a snapshot of the current peers using an ao2_callback with the
>OBJ_MULTIPLE flag.  This size of the array is set to the number of peers
>that the iterator will iterate over; hence, if peers are added or removed
>from the peers container it will not affect the execution of the "sip show
>peers" command.
>
>Review: https://reviewboard.asterisk.org/r/1738/
>
>(closes issue ASTERISK-19231)
>(closes issue ASTERISK-19361)
>Reported by: Thomas Arimont, Jamuel Starkey
>Tested by: Thomas Arimont, Jamuel Starkey
>Patches: sip_show_peers_2012_02_16.diff uploaded by mjordan (license 6283)
>
>
>


--
This message is automatically generated by Atlassian Bamboo
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/test-results/attachments/20120222/b8c7ea41/attachment-0001.htm>