[test-results] [Bamboo] Asterisk - Trunk > Mac OS X Snow Leopard (10.6) > #311 has FAILED. Change made by Russell Bryant and seanbright.

Bamboo bamboo at asterisk.org
Fri Jul 29 15:07:46 CDT 2011


-----------------------------------------------------------------------
Asterisk - Trunk > Mac OS X Snow Leopard (10.6) > #311 failed.
-----------------------------------------------------------------------
This build occurred because it is a dependant of ASTTRUNK-LUCID-810.
No failed tests found, a possible compilation error.

http://bamboo.asterisk.org/browse/ASTTRUNK-SNOWLEOPARD-311/


--------------
Failing Jobs
--------------
  - x86_64 (Default Stage): No tests found.


--------------
Code Changes
--------------
Russell Bryant (330273):

>astobj2: Avoid using temporary objects + ao2_find() with OBJ_POINTER.
>
>There is a fairly common pattern making its way through the code base where we
>put a temporary object on the stack so we can call ao2_find() with OBJ_POINTER.
>The purpose is so that it can be passed into the object hash function.
>However, this really seems like a hack and potentially error prone.  This patch
>is a first stab at approach to avoid having to do that.
>
>It adds a new flag, OBJ_KEY, which can be used instead of OBJ_POINTER in these
>situations.  Then, the hash function can know whether it was given an object or
>some custom data to hash.
>
>The patch also changes some uses of ao2_find() for iax2_user and iax2_peer
>objects to reflect how OBJ_KEY would be used.
>
>So long, and thanks for all the fish.
>
>Review: https://reviewboard.asterisk.org/r/1184/
>

seanbright (330205):

>Merged revisions 330204 via svnmerge from 
>https://origsvn.digium.com/svn/asterisk/branches/10
>
>................
>  r330204 | seanbright | 2011-07-29 12:58:40 -0400 (Fri, 29 Jul 2011) | 9 lines
>  
>  Merged revisions 330203 via svnmerge from 
>  https://origsvn.digium.com/svn/asterisk/branches/1.8
>  
>  ........
>    r330203 | seanbright | 2011-07-29 12:58:08 -0400 (Fri, 29 Jul 2011) | 2 lines
>    
>    Only write to wav files that were opened to be written to.
>  ........
>................
>

seanbright (330221):

>Merged revisions 330217 via svnmerge from 
>https://origsvn.digium.com/svn/asterisk/branches/10
>
>................
>  r330217 | seanbright | 2011-07-29 13:19:42 -0400 (Fri, 29 Jul 2011) | 9 lines
>  
>  Merged revisions 330213 via svnmerge from 
>  https://origsvn.digium.com/svn/asterisk/branches/1.8
>  
>  ........
>    r330213 | seanbright | 2011-07-29 13:18:56 -0400 (Fri, 29 Jul 2011) | 2 lines
>    
>    Correct the check for O_RDONLY.
>  ........
>................
>


--
This message is automatically generated by Atlassian Bamboo
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/test-results/attachments/20110729/35b5f504/attachment-0001.htm>


More information about the Test-results mailing list