[svn-commits] wdoekes: branch 1.8 r425291 - /branches/1.8/Makefile

[SVN commits to the Digium repositories]

Author: wdoekes
Date: Sun Oct 12 02:50:23 2014
New Revision: 425291

URL: http://svnview.digium.com/svn/asterisk?view=rev&rev=425291
Log:
build: Relax badshell tilde test to allow for ~ in middle of DESTDIR.

The main Makefile has a target test called 'badshell' that tests if
DESTDIR does not happen to have an an-expanded tilde (~).  This might
be the case if you run: make install DESTDIR=~/somewhere/

That test also disallowed valid tildes in directory names. The test is
now changed to only trigger on a tilde at the start of the path.

ASTERISK-13797 #close
Reported by: Tzafrir Cohen

Review: https://reviewboard.asterisk.org/r/4064/

Modified:
    branches/1.8/Makefile

Modified: branches/1.8/Makefile
URL: http://svnview.digium.com/svn/asterisk/branches/1.8/Makefile?view=diff&rev=425291&r1=425290&r2=425291
==============================================================================
--- branches/1.8/Makefile (original)
+++ branches/1.8/Makefile Sun Oct 12 02:50:23 2014
@@ -539,7 +539,7 @@
 	fi
 
 badshell:
-ifneq ($(findstring ~,$(DESTDIR)),)
+ifneq ($(filter ~%,$(DESTDIR)),)
 	@echo "Your shell doesn't do ~ expansion when expected (specifically, when doing \"make install DESTDIR=~/path\")."
 	@echo "Try replacing ~ with \$$HOME, as in \"make install DESTDIR=\$$HOME/path\"."
 	@exit 1