[svn-commits] dlee: trunk r409091 - in /trunk: ./ utils/astman.c

[SVN commits to the Digium repositories]

Author: dlee
Date: Thu Feb 27 10:26:18 2014
New Revision: 409091

URL: http://svnview.digium.com/svn/asterisk?view=rev&rev=409091
Log:
Fix memory stomping bug in astman.

This memset complained in dev mod on my Ubuntu box. The memset is both
unnecessary and dangerous. At this point, m hasn't been initialized
yet, so the memset will write off to whatever address happens to be
on the stack at the time.
........

Merged revisions 409077 from http://svn.asterisk.org/svn/asterisk/branches/1.8
........

Merged revisions 409083 from http://svn.asterisk.org/svn/asterisk/branches/11
........

Merged revisions 409087 from http://svn.asterisk.org/svn/asterisk/branches/12

Modified:
    trunk/   (props changed)
    trunk/utils/astman.c

Propchange: trunk/
------------------------------------------------------------------------------
Binary property 'branch-12-merged' - no diff available.

Modified: trunk/utils/astman.c
URL: http://svnview.digium.com/svn/asterisk/trunk/utils/astman.c?view=diff&rev=409091&r1=409090&r2=409091
==============================================================================
--- trunk/utils/astman.c (original)
+++ trunk/utils/astman.c Thu Feb 27 10:26:18 2014
@@ -737,7 +737,6 @@
 					show_message("Login Failed", get_header(m, "Message"));
 				}
 			} else {
-				memset(m, 0, sizeof(*m));
 				manager_action("Login", 
 					"Username: %s\r\n"
 					"Secret: %s\r\n",